Repository navigation
feat: return path and stable reasons from get_project_metadata - #21
Merged
Merged
Conversation
Callers compare the reason strings, so they are now documented as a stable API. The unreadable case also returns the QUARTO_EXECUTE_INFO path, so a caller can name the file without reading the variable again.
mcanouil
added
the
Type: Enhancement 💡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_project_metadatanow returns theQUARTO_EXECUTE_INFOpath as a third value, alongside each of its four failure reasons.A caller that warns about the file can name it without reading the variable again.
The reasons themselves are now documented as a stable API in the doc comment.
Extensions that keep their own warnings compare against these exact strings, so a rename would silence them with no error.
The existing tests already pin each string, and now also check the returned path.
The in-repo caller,
get_project_repo_url, reads only the first value, so it is unchanged.