Repository navigation
test: print the summary when a module does not load - #18
Merged
Merged
Conversation
The loading section recorded a failed load and went on, then the first section that used the missing module raised and ended the run with no summary. The suite now stops after loading when a module failed, and prints the summary line through one exit path.
A module that loads and returns something other than a table failed the check with no detail and a stop line that said it did not load. Both now say what happened.
Not every later section indexes a loaded module, so the comment now says the stop is a choice and why.
The suite later replaces os.exit with a counting stub, so the helper now holds the real function from the start.
mcanouil
added
the
Type: Refactor 🔥
mcanouil
marked this pull request as ready for review
October 29, 2026 11:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite could end without its summary line.
When a module failed to load, the loading section recorded the failure and carried on.
The first later section that used the missing module raised an error, and the run ended with no
N checks, M failedline.The suite now stops after loading when any module failed its load check.
It prints the usual summary line through one exit path and exits 1.
A module that loads but returns something other than a table now says what it returned.
I checked this by breaking
paths.luain a clean clone.Before the change the run ended with exit 84 and no summary, and now it prints
11 checks, 1 failedand exits 1.The healthy suite still gives 238 checks, 0 failed.
tests/is not shipped, so this needs no release.