feat(web): shadcn-solid component library (PLAN §4.5)#19
Merged
Conversation
- Add Tailwind v4 (@tailwindcss/vite), tailwindcss-animate, CVA, clsx, tailwind-merge; cn() helper and Biome css.tailwindDirectives - Document COMPONENT_LIBRARY.md (shadcn-solid workflow, CLI); README pointer - shadcn-solid-style Button + buttonVariants; recipe back link uses buttonVariants on Router A per docs - Tick PLAN §4.5 Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
This PR implements PLAN §4.5 for apps/web by standardizing the UI component approach on the shadcn-solid “registry” pattern (vendored components/ui/*) and introducing the supporting Tailwind/CVA tooling.
Changes:
- Added Tailwind CSS v4 via
@tailwindcss/vite, plus shadcn-solid-adjacent utilities (cva,clsx,tailwind-merge,tailwindcss-animate,@kobalte/core). - Introduced
cn()helper and a vendoredButton(components/ui/button.tsx) withbuttonVariants. - Adopted the new
buttonVariantsstyling for the “← All recipes” link onRecipePage, removing the old page-specific link CSS, and documented the workflow.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Locks new Tailwind/CVA/Kobalte dependencies needed for shadcn-solid-style components. |
| PLAN.md | Marks §4.5 complete and slightly refines the wording of the task. |
| apps/web/vite.config.ts | Adds the Tailwind v4 Vite plugin. |
| apps/web/src/index.css | Enables Tailwind via @import "tailwindcss" and registers tailwindcss-animate. |
| apps/web/src/lib/utils.ts | Adds cn() (clsx + tailwind-merge) helper used by UI components. |
| apps/web/src/components/ui/button.tsx | Adds vendored shadcn-solid Button and buttonVariants (wrapping Kobalte). |
| apps/web/src/pages/RecipePage.tsx | Uses buttonVariants on <A> for the back link. |
| apps/web/src/pages/Page.css | Removes now-redundant .recipe-detail-back-link styling. |
| apps/web/package.json | Adds new runtime + dev dependencies for Tailwind and shadcn-solid patterns. |
| apps/web/biome.json | Enables Biome CSS parsing support for Tailwind directives. |
| apps/web/README.md | Links the chosen component library workflow documentation. |
| apps/web/COMPONENT_LIBRARY.md | Documents the decision and workflow for shadcn-solid registry components. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…p to §4.8 Made-with: Cursor
…edundant cn) Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements PLAN §4.5: standardise on shadcn-solid (registry-style
components/ui, Tailwind,cn(), CVA). Documents the workflow inapps/web/COMPONENT_LIBRARY.mdand links from the app README.Changes
@tailwindcss/vite),tailwindcss-animate,class-variance-authority,clsx,tailwind-merge;@kobalte/corefor the registryButtonimplementation (no separate “Kobalte vs shadcn” choice — shadcn-solid components wrap Kobalte by design).css.parser.tailwindDirectivesfor@import "tailwindcss"/@plugin.src/components/ui/button.tsx(Button+buttonVariants); RecipePage “← All recipes” usesbuttonVariantson<A>per shadcn-solid Button docs.Checklist
pnpm --filter web lintpnpm --filter web testpnpm --filter web buildFollow-up
Run
pnpm dlx shadcn-solid@latest init/add <component>when registry access is available to refresh files from upstream.Made with Cursor