Fix repl and other misc code, including test#211
Open
michalz-zoom wants to merge 6 commits intomaxtaco:iced2from
Open
Fix repl and other misc code, including test#211michalz-zoom wants to merge 6 commits intomaxtaco:iced2from
michalz-zoom wants to merge 6 commits intomaxtaco:iced2from
Conversation
Node.js 'assert' module complains if we try to use assert.throws to
check an exception that is literally Error('error') has a message
'error', saying that it's ambiguous.
We were calling fs.unlink without providing callback, so this test was failing to clean up its temporary file.
michalz-zoom
force-pushed
the
michalz/fix-repl
branch
from
a8ebb71 to
d015fcb
Compare
Author
|
@maxtaco please take a look :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bufferconstructor calls which are deprecated.ok,failetc.), also add a way to run single (or multiple) test files instead of full test suite.