Fix RTL layout mirroring and wipe animations for lyrics#2150
Open
chosendango wants to merge 1 commit into
Open
Fix RTL layout mirroring and wipe animations for lyrics#2150chosendango wants to merge 1 commit into
chosendango wants to merge 1 commit into
Conversation
v1.4.0: New version
Owner
|
Please show demo, screenshot, screenrecord |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves UI issues when viewing lyrics that contain right-to-left scripts (like Arabic).
Changes:
RichSyncLyricsLineItemandLyricsLineItemtext layouts in a dynamicCompositionLocalProviderto enforceLayoutDirection.RtlorLayoutDirection.Ltrbased on the specific line's character directionality.clipRectbounds insideAnimatedWordso the karaoke wipe animation natively flows right-to-left for RTL text.