Allow different web server than nginx#24
Open
webflo wants to merge 8 commits intomattheath:masterfrom
Open
Conversation
* origin/master: Bump version to 0.5.6, fixes more zlib issues Detect broken versions of PHP and fail existence check libtool patch isn’t required for zlib 1.2.8. Require zlib 1.2.8 in manifest. Update zlib to 1.2.8. Bump cardboard dependency Bump version Add 5.3.24, 5.4.12, 5.4.13, 5.4.14. Lint mcrypt manifest Add mcrypt extension, using php_source provider Add php extension provider which can build extensions bundled in the php source
|
Apparently this is good to merge :-) |
mattheath
added a commit
that referenced
this pull request
Jan 2, 2014
Add the OAuth Pecl extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it makes sense to decouple the webserver configuration from php::fpm::fastcgi and php::fpm::service for more flexibility.
I am not sure if this is a good approach to do this. I relatively new to puppet.
Thanks!