Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion server/plugin/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -859,7 +859,15 @@ func fetchReviews(c *UserContext, client *github.Client, repoOwner string, repoN
return []*github.PullRequestReview{}, errors.Wrap(err, "could not list reviews")
}

return reviewsList, nil
// Filtering reviews where user is nil
filtered := make([]*github.PullRequestReview, 0, len(reviewsList))
for _, review := range reviewsList {
if review != nil && review.User != nil {
filtered = append(filtered, review)
}
}

return filtered, nil
}

func getRepoOwnerAndNameFromURL(rawURL string) (string, string, error) {
Expand Down
6 changes: 5 additions & 1 deletion webapp/src/components/sidebar_right/github_items.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,11 @@ function getReviewText(item: GithubItem, style: any, secondLine: boolean) {
};

const lastReviews = item.reviews.reduce(reverse, []).filter((v) => {
if (v.user.login === item.user.login) {
if (!v.user) {
return false;
}

if (item.user && v.user.login === item.user.login) {
return false;
}

Expand Down
2 changes: 1 addition & 1 deletion webapp/src/types/github_types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type GitHubUser = {

export type Review = {
state: string;
user: GitHubUser;
user?: GitHubUser;
}

export type GithubItem = PrsDetailsData & {
Expand Down
Loading