fix only full group by by daviszhen · Pull Request #26635 · matrixorigin/matrixone

daviszhen · 2026-08-03T08:42:33Z

What type of PR is this?

Which issue(s) this PR fixes:

What this PR does / why we need it:

未开启 ONLY_FULL_GROUP_BY：保持原有宽松行为。
开启且无 MATRIXONE_NATIVE：
- 允许 WHERE 限制为单值的非分组列。
- 允许依赖完整主键的非分组列。
同时包含 MATRIXONE_NATIVE：保持 MatrixOne 原生严格校验。
支持 SELECT、HAVING、ORDER BY，并处理组合主键、ROLLUP/CUBE、ENUM/SET、带点号列名等边界。
SQL mode 改变时清理普通计划缓存，并重建模式不匹配的 PREPARE 计划。
新增独立 BVT SQL/result 文件及 planner、frontend 回归测试。

# Conflicts: # pkg/frontend/computation_wrapper.go # pkg/frontend/mysql_cmd_executor.go # pkg/sql/plan/query_builder.go # pkg/sql/plan/types.go

qodo-code-review · 2026-08-03T08:42:40Z

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

XuPeng-SH

Request changes: keep the newly allowed columns valid across the aggregate/window stage boundary.

A valid single-value exception fails to build as soon as that column is consumed by a window function:

SELECT deptno,
       FIRST_VALUE(job) OVER (),
       SUM(sal)
FROM constraint_test.emp
WHERE job = 'clerk'
GROUP BY deptno;

Under ONLY_FULL_GROUP_BY, job is statement-wide single-valued, so this is the same deterministic case this PR is intended to allow. On exact head dbea0aaa827d, a planner regression expecting BuildPlan to succeed instead fails with Column remapping failed: cannot find column reference. The failing aggregate contains any_value(first_value(emp.job) over (...)): wrapBareColRefsInAnyValue walks every project after validation, sees the window-tag project as a bare column, and creates a pre-window aggregate that references a post-window result. Meanwhile, the raw window input also has to be materialized from the aggregate output.

Please rewrite allowed raw window arguments/partition/order expressions to group/aggregate outputs, while leaving the window-result tag above the aggregate stage. Add regressions for both exception shapes (WHERE-single-valued and PK-dependent) in window arguments/order keys. The PR's focused OFGB and sql-mode/prepared-cache tests pass, so this stage boundary is currently uncovered.

daviszhen · 2026-08-04T10:48:52Z

Request changes: keep the newly allowed columns valid across the aggregate/window stage boundary.

A valid single-value exception fails to build as soon as that column is consumed by a window function:
SELECT deptno,
       FIRST_VALUE(job) OVER (),
       SUM(sal)
FROM constraint_test.emp
WHERE job = 'clerk'
GROUP BY deptno;
Under ONLY_FULL_GROUP_BY, job is statement-wide single-valued, so this is the same deterministic case this PR is intended to allow. On exact head dbea0aaa827d, a planner regression expecting BuildPlan to succeed instead fails with Column remapping failed: cannot find column reference. The failing aggregate contains any_value(first_value(emp.job) over (...)): wrapBareColRefsInAnyValue walks every project after validation, sees the window-tag project as a bare column, and creates a pre-window aggregate that references a post-window result. Meanwhile, the raw window input also has to be materialized from the aggregate output.

Please rewrite allowed raw window arguments/partition/order expressions to group/aggregate outputs, while leaving the window-result tag above the aggregate stage. Add regressions for both exception shapes (WHERE-single-valued and PK-dependent) in window arguments/order keys. The PR's focused OFGB and sql-mode/prepared-cache tests pass, so this stage boundary is currently uncovered.

防止窗口结果 windowTag 被错误包进聚合 any_value()，保持在 AGG 之后的 WINDOW/PROJECT 阶段。
将窗口函数参数、PARTITION BY、ORDER BY 中允许的裸列改写为聚合输出，避免 AGG 引用窗口阶段列。
新增规划器 UT：WHERE 单值约束、原始 OVER ()、主键函数依赖三种场景。
新增对应 OFGB BVT 及结果文件，覆盖窗口参数、分区键与排序键。

# Conflicts: # pkg/sql/plan/base_binder.go

XuPeng-SH

Re-reviewed exact head 7de4fc4. The previously reported aggregate/window stage-boundary failure is fixed: windowTag results remain above AGG, while allowed raw window arguments, PARTITION BY expressions, and ORDER BY expressions are materialized through aggregate outputs. I verified the focused planner/frontend regressions plus additional edge cases for window-only ORDER BY, isolated partition/order keys, nested scalar wrappers, mixed safe/unsafe columns, reverse equality, OR rejection, and ROLLUP. Build/vet and current CI are green. No blocking findings.

mergify · 2026-08-04T14:15:42Z

Merge Queue Status

✅ Entered queue — 2026-08-04 14:15 UTC · Rule: main · triggered by rule Automatic queue on approval for main
❌ Checks failed · in-place
🚫 Left the queue — 2026-08-04 14:31 UTC · at e2a00c60a05777173c9cc45e5de6c7831e7af0f9

This pull request spent 16 minutes 21 seconds in the queue, with no time running CI.

Waiting for

All conditions

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Tick the box to put this pull request back in the merge queue (same as @mergifyio queue).

Requeue this pull request

daviszhen added 3 commits August 3, 2026 15:59

update

cf75bf8

update

beda478

Merge branch 'main' into 0803-only-full-group-by

0d0c9b1

# Conflicts: # pkg/frontend/computation_wrapper.go # pkg/frontend/mysql_cmd_executor.go # pkg/sql/plan/query_builder.go # pkg/sql/plan/types.go

daviszhen requested review from XuPeng-SH, aunjgr and heni02 as code owners August 3, 2026 08:42

daviszhen temporarily deployed to ci August 3, 2026 08:42 — with GitHub Actions Inactive

daviszhen had a problem deploying to ci August 3, 2026 08:42 — with GitHub Actions Failure

daviszhen temporarily deployed to ci August 3, 2026 08:42 — with GitHub Actions Inactive

daviszhen had a problem deploying to ci August 3, 2026 08:42 — with GitHub Actions Failure

daviszhen temporarily deployed to ci August 3, 2026 08:42 — with GitHub Actions Inactive

daviszhen temporarily deployed to ci August 3, 2026 08:43 — with GitHub Actions Inactive

matrix-meow added the size/L Denotes a PR that changes [500,999] lines label Aug 3, 2026

mergify Bot added the kind/bug Something isn't working label Aug 3, 2026

daviszhen had a problem deploying to ci August 3, 2026 09:20 — with GitHub Actions Failure

daviszhen added 2 commits August 3, 2026 18:35

test: initialize sql mode in dependent bvt cases

721b662

update

478705c

daviszhen had a problem deploying to ci August 3, 2026 10:53 — with GitHub Actions Error

daviszhen temporarily deployed to ci August 3, 2026 10:53 — with GitHub Actions Inactive

daviszhen had a problem deploying to ci August 3, 2026 10:53 — with GitHub Actions Error

matrix-meow added size/XL Denotes a PR that changes [1000, 1999] lines and removed size/L Denotes a PR that changes [500,999] lines labels Aug 3, 2026

Merge branch 'main' into 0803-only-full-group-by

fdfe362

daviszhen temporarily deployed to ci August 3, 2026 10:54 — with GitHub Actions Inactive

daviszhen temporarily deployed to ci August 4, 2026 07:27 — with GitHub Actions Inactive

daviszhen temporarily deployed to ci August 4, 2026 08:05 — with GitHub Actions Inactive

Merge branch 'main' into 0803-only-full-group-by

dbea0aa

daviszhen temporarily deployed to ci August 4, 2026 08:14 — with GitHub Actions Inactive

daviszhen temporarily deployed to ci August 4, 2026 08:52 — with GitHub Actions Inactive

XuPeng-SH requested changes Aug 4, 2026

View reviewed changes

heni02 approved these changes Aug 4, 2026

View reviewed changes

update

f538ddc

daviszhen had a problem deploying to ci August 4, 2026 10:48 — with GitHub Actions Error

daviszhen temporarily deployed to ci August 4, 2026 10:48 — with GitHub Actions Inactive

daviszhen had a problem deploying to ci August 4, 2026 10:49 — with GitHub Actions Error

Merge branch 'main' into 0803-only-full-group-by

ae1d38f

daviszhen temporarily deployed to ci August 4, 2026 10:49 — with GitHub Actions Inactive

Merge branch 'main' into 0803-only-full-group-by

7de4fc4

# Conflicts: # pkg/sql/plan/base_binder.go

XuPeng-SH approved these changes Aug 4, 2026

View reviewed changes

Merge branch 'main' into 0803-only-full-group-by

e2a00c6

Navigation Menu

Uh oh!

fix only full group by - #26635

fix only full group by#26635
daviszhen wants to merge 15 commits into
matrixorigin:mainfrom
daviszhen:0803-only-full-group-by

daviszhen commented Aug 3, 2026

Uh oh!

qodo-code-review Bot commented Aug 3, 2026

Uh oh!

XuPeng-SH left a comment

Uh oh!

daviszhen commented Aug 4, 2026

Uh oh!

XuPeng-SH left a comment

Uh oh!

mergify Bot commented Aug 4, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

daviszhen commented Aug 3, 2026

What type of PR is this?

Which issue(s) this PR fixes:

What this PR does / why we need it:

Uh oh!

qodo-code-review Bot commented Aug 3, 2026

Qodo reviews are paused for this user.

Uh oh!

XuPeng-SH left a comment

Choose a reason for hiding this comment

Uh oh!

daviszhen commented Aug 4, 2026

Uh oh!

XuPeng-SH left a comment

Choose a reason for hiding this comment

Uh oh!

mergify Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mergify Bot commented Aug 4, 2026 •

edited

Loading