Skip to content

Switch to uniffi-bindgen-go v0.5.0+v0.29.5 #224

Merged
kegsay merged 2 commits intomatrix-org:mainfrom
Johennes:johannes/2026-01-upgrade-to-0.29
Mar 6, 2026
Merged

Switch to uniffi-bindgen-go v0.5.0+v0.29.5 #224
kegsay merged 2 commits intomatrix-org:mainfrom
Johennes:johannes/2026-01-upgrade-to-0.29

Conversation

@Johennes
Copy link
Contributor

@Johennes Johennes commented Feb 16, 2026

This is to try out NordSecurity/uniffi-bindgen-go#86.

With these changes applied the tests appear to pass for me locally:

$ COMPLEMENT_CRYPTO_TEST_CLIENT_MATRIX=rr \
COMPLEMENT_BASE_IMAGE=ghcr.io/matrix-org/synapse-service:v1.117.0 \
LIBRARY_PATH=$LIBRARY_PATH:_temp_rust_sdk/target/debug \
LD_LIBRARY_PATH=$LD_LIBRARY_PATH:_temp_rust_sdk/target/debug \
go test -v -count=1 -tags=rust -timeout 15m ./tests

...

    rust.go:518: @user-156-alice:hs1: Stopping sync service
    to_device_test.go:350: [@user-157-bob:hs1](rust) Close
    to_device_test.go:350: [@user-156-alice:hs1](rust) Close
--- PASS: TestToDeviceMessagesArentLostWhenKeysQueryFails (5.19s)
    --- PASS: TestToDeviceMessagesArentLostWhenKeysQueryFails/rust (5.19s)
=== RUN   TestToDeviceMessagesAreProcessedInOrder
=== RUN   TestToDeviceMessagesAreProcessedInOrder/rust
    to_device_test.go:424: flakey
--- PASS: TestToDeviceMessagesAreProcessedInOrder (0.00s)
    --- SKIP: TestToDeviceMessagesAreProcessedInOrder/rust (0.00s)
=== RUN   TestVerificationSAS
=== RUN   TestVerificationSAS/{rust_hs1}|{rust_hs1}
    verification_test.go:62: rust cannot be a verifiee yet, see https://github.com/matrix-org/matrix-rust-sdk/issues/3595
--- PASS: TestVerificationSAS (0.00s)
    --- SKIP: TestVerificationSAS/{rust_hs1}|{rust_hs1} (0.00s)
PASS
2026/02/16 15:21:29 🐳 Stopping container: 0773fcc8a206
2026/02/16 15:21:29 ✅ Container stopped: 0773fcc8a206
2026/02/16 15:21:29 🐳 Terminating container: 0773fcc8a206
2026/02/16 15:21:29 🚫 Container terminated: 0773fcc8a206
ok  	github.com/matrix-org/complement-crypto/tests	179.778s

@Johennes Johennes force-pushed the johannes/2026-01-upgrade-to-0.29 branch 2 times, most recently from a229d40 to dde063b Compare February 16, 2026 12:50
@kegsay kegsay marked this pull request as ready for review February 17, 2026 08:22
Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes so LGTM.

You can either keep it pinned to the tnull fork or wait for the Nord review, but you may be waiting a while.

@kaylendog
Copy link
Contributor

Looks like the Nord review has come through, if @kegsay has time to do a release on their fork?

@Johennes Johennes changed the title Try out https://github.com/tnull/uniffi-bindgen-go/tree/2026-01-upgrade-to-0.29 Switch to uniffi-bindgen-go v0.5.0+v0.29.5 Mar 6, 2026
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes Johennes force-pushed the johannes/2026-01-upgrade-to-0.29 branch from 3423a71 to bdd066d Compare March 6, 2026 10:36
@kegsay kegsay merged commit a22761c into matrix-org:main Mar 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants