Repository navigation
Show a Parameter's and a Signal's Definition File in its column, 1.10.1 - #120
Merged
Merged
Conversation
core now projects a Parameter's and a Signal's Definition File (CoderInfo.CustomAttributes.DefinitionFile) as the definitionFile cell, read-only like the Header File: the column a VariantBankCoderInfo's DefinitionFile shows in, which stayed blank for them. A name typed under Other Properties that is a built-in column's (DefinitionFile, "Definition File") shows that column, so it now shows the value. core is pinned to its branch (mathworks/data-explorer-core#274) until its release; the goldens are refreshed for it (REFRESH_GOLDENS=1). The only change: a blank definitionFile cell on every row that shows a Header File, 145 of them, and the digests of rows that hold one. With those blank cells taken out of the answers, every old golden passes as it was (79 of 79). propertyCells.test.ts holds the cell to MATLAB's text and binary dictionaries (test-integration/fixtures/cscattributes): pExport's p_export.c, and blank under GetSet, Struct and Auto. Both new checks fail on core v1.59.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a Parameter or Signal, the table's Definition File column now shows the object's Definition File, as it does for a Variant Bank's coder info. Typing
DefinitionFileunder Other Properties already pointed at this built-in column, so that now shows the value too.core: Show a Parameter's and a Signal's Definition File as a table column data-explorer-core#274 projects
CoderInfo.CustomAttributes.DefinitionFileas thedefinitionFilecell. It is read-only like the Header File and blank under a storage class without one.v1.60.0(released) and bumps view to 1.10.1.View code: no change, only the
COLUMNScomment inrowBuilder.ts. The column, its label and its group were already here.Goldens: refreshed with
REFRESH_GOLDENS=1. The diff is only the new cell:definitionFileon every row that shows a Header File (145);With those blank cells taken out of the answers, every old golden passes unchanged (79 of 79).
Tests:
propertyCells.test.tschecks the cell against MATLAB's text and binary dictionaries (test-integration/fixtures/cscattributes). pExport showsp_export.c; GetSet, Struct and Auto show blank. Both new checks fail on core v1.59.0.npm run verifypasses: 7,531 tests.Merging this also turns view
maingreen against coremainagain: its goldens need the new cell.