Skip to content

Show a Parameter's and a Signal's Definition File in its column, 1.10.1 - #120

Merged
ww-mw merged 3 commits into
mainfrom
schema/csc-definition-file
Nov 18, 2026
Merged

ww-mw merged 3 commits into
mainfrom
schema/csc-definition-file

Conversation

@ww-mw

@ww-mw ww-mw commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

For a Parameter or Signal, the table's Definition File column now shows the object's Definition File, as it does for a Variant Bank's coder info. Typing DefinitionFile under Other Properties already pointed at this built-in column, so that now shows the value too.

  • core: Show a Parameter's and a Signal's Definition File as a table column data-explorer-core#274 projects CoderInfo.CustomAttributes.DefinitionFile as the definitionFile cell. It is read-only like the Header File and blank under a storage class without one.

    • This branch pins core v1.60.0 (released) and bumps view to 1.10.1.
  • View code: no change, only the COLUMNS comment in rowBuilder.ts. The column, its label and its group were already here.

  • Goldens: refreshed with REFRESH_GOLDENS=1. The diff is only the new cell:

    • a blank definitionFile on every row that shows a Header File (145);
    • the digests of rows that hold one.

    With those blank cells taken out of the answers, every old golden passes unchanged (79 of 79).

  • Tests: propertyCells.test.ts checks the cell against MATLAB's text and binary dictionaries (test-integration/fixtures/cscattributes). pExport shows p_export.c; GetSet, Struct and Auto show blank. Both new checks fail on core v1.59.0.

  • npm run verify passes: 7,531 tests.

Merging this also turns view main green against core main again: its goldens need the new cell.

core now projects a Parameter's and a Signal's Definition File
(CoderInfo.CustomAttributes.DefinitionFile) as the definitionFile cell,
read-only like the Header File: the column a VariantBankCoderInfo's
DefinitionFile shows in, which stayed blank for them. A name typed under
Other Properties that is a built-in column's (DefinitionFile, "Definition
File") shows that column, so it now shows the value.

core is pinned to its branch (mathworks/data-explorer-core#274) until
its release; the goldens are refreshed for it (REFRESH_GOLDENS=1). The
only change: a blank definitionFile cell on every row that shows a
Header File, 145 of them, and the digests of rows that hold one. With
those blank cells taken out of the answers, every old golden passes as
it was (79 of 79).

propertyCells.test.ts holds the cell to MATLAB's text and binary
dictionaries (test-integration/fixtures/cscattributes): pExport's
p_export.c, and blank under GetSet, Struct and Auto. Both new checks
fail on core v1.59.0.
@ww-mw ww-mw changed the title Show a Parameter's and a Signal's Definition File in its column Show a Parameter's and a Signal's Definition File in its column, 1.10.1 Nov 18, 2026
@ww-mw
ww-mw merged commit 9e3005a into main Nov 18, 2026
6 checks passed
@ww-mw
ww-mw deleted the schema/csc-definition-file branch November 18, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant