Repository navigation
Columns menu: fold and check groups, Alt+Up/Down moves, storage class attribute columns (1.10.0) - #119
Merged
Conversation
The 1.8.0 bump moved package.json's core devDependency to #v1.59.0 but left the lockfile resolving v1.58.0's commit (dd49527), which npm ci installs without a word: view's tests and CI have run against core 1.58.0 since. The lockfile now resolves fdbd277, v1.59.0's commit; the full suite and the goldens pass unchanged on it.
…n, and read storage class attributes as property columns The rest of the in-MATLAB data explorer's Columns dropdown (its design's G2-G4 and G8): - Each group's header has a toggle (a click on its name folds too), a box over the group's columns and "a of b". A group opens expanded when it shows a column. The window keeps each group's fold for every table of the storageKey, saves it nowhere, and Reset leaves it alone. Opening the menu writes the state down, so unchecking a group's last column does not fold it. The box is mixed while some columns show; on a group that shows all it hides them, on any other it shows them all, and Name stays shown. Other Properties has the same header; folded, it keeps its field, and Add unfolds it. - Alt+Up/Down on a column moves it one place within its group (never past Name), the focus following it and a live region saying "<column> moved to position i of n". Opening the menu focuses its first column box; Escape anywhere in it closes it, back on the Columns button. - A property column whose name the object has no top-level property of reads its storage class's attribute of that name (CoderInfo.CustomAttributes.GetFunction as GetFunction). A top-level property of the name wins whatever its value; a built-in column's name never reads one. Typed as CoderInfo.CustomAttributes.X, the column is X; a refused name's notice quotes what was typed. A binary dictionary keeps each nested object as a 1x1 object array, which is read the same. test-integration/fixtures/cscattributes holds a text and a binary dictionary MATLAB wrote with ExportToFile, GetSet and Struct attributes (make_csc_attributes.m, which also prints what MATLAB reads back); a folder of its own, so no folder golden lists it. No golden changes: no other fixture has a storage class with attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.10.0, on core v1.59.0. This adds the parts of the in-MATLAB data explorer's Columns dropdown that 1.9.0 left out (its design's G2–G4 and G8).
Group headers. Each group has a toggle (▸/▾; clicking the name folds it too), a box over the group's columns, and "a of b".
storageKey. It is never saved, and Reset leaves it alone. Opening the menu writes the state down, so unchecking a group's last column doesn't fold it away.Keyboard.
Storage class attributes. A property column whose name the object has no top-level property of reads the storage class's attribute of that name. For example,
GetFunctionreadsCoderInfo.CustomAttributes.GetFunction.CoderInfo.CustomAttributes.Xmakes the columnX. A refused name's notice quotes what was typed.test-integration/fixtures/cscattributesholds a text and a binary dictionary that MATLAB wrote with ExportToFile, GetSet and Struct attributes.make_csc_attributes.malso prints what MATLAB reads back. The fixtures are in a folder of their own, so no folder golden lists them.Also: the lockfile now resolves core v1.59.0, the version
package.jsonpins. Since the 1.8.0 bump it had still resolved v1.58.0's commit, so tests and CI ran on 1.58.0. The suite and the goldens pass unchanged on 1.59.0.Not in this release: the built-in Definition File column reads only a
Simulink.VariantBankCoderInfo's field. Core's Parameter and Signal schemas don't projectCoderInfo.CustomAttributes.DefinitionFileinto rows, so a parameter's DefinitionFile stays empty. That needs a core change.Checks
npm run verify: 396 files, 7,530 tests passed, 1 skipped; boundary, version, API and leak checks OK. No golden changes.