Skip to content

Columns menu: fold and check groups, Alt+Up/Down moves, storage class attribute columns (1.10.0) - #119

Merged
ww-mw merged 3 commits into
mainfrom
table/column-menu-groups
Nov 17, 2026
Merged

ww-mw merged 3 commits into
mainfrom
table/column-menu-groups

Conversation

@ww-mw

@ww-mw ww-mw commented Nov 17, 2026

Copy link
Copy Markdown
Member

Release 1.10.0, on core v1.59.0. This adds the parts of the in-MATLAB data explorer's Columns dropdown that 1.9.0 left out (its design's G2–G4 and G8).

Group headers. Each group has a toggle (▸/▾; clicking the name folds it too), a box over the group's columns, and "a of b".

  • Fold. A group opens expanded when it shows a column. The window keeps each group's fold for every table with the same storageKey. It is never saved, and Reset leaves it alone. Opening the menu writes the state down, so unchecking a group's last column doesn't fold it away.
  • Box. The box is mixed while some of the group's columns show. On a group that shows all of them, it hides them all; on any other, it shows them all. Name stays shown either way.
  • Other Properties has the same header. Folded, it keeps its field, and Add unfolds it.

Keyboard.

  • Alt+↑/↓ on a column moves it one place within its group, never past Name. The focus follows the column, and a live region says "column moved to position i of n".
  • Opening the menu puts the focus on its first column box.
  • Escape anywhere in the menu closes it and returns the focus to the Columns button.

Storage class attributes. A property column whose name the object has no top-level property of reads the storage class's attribute of that name. For example, GetFunction reads CoderInfo.CustomAttributes.GetFunction.

  • A top-level property of the same name wins, whatever its value.
  • A built-in column's name never reads an attribute.
  • Typing CoderInfo.CustomAttributes.X makes the column X. A refused name's notice quotes what was typed.
  • A binary dictionary keeps each nested object as a 1×1 object array; it is read the same way.
  • test-integration/fixtures/cscattributes holds a text and a binary dictionary that MATLAB wrote with ExportToFile, GetSet and Struct attributes. make_csc_attributes.m also prints what MATLAB reads back. The fixtures are in a folder of their own, so no folder golden lists them.

Also: the lockfile now resolves core v1.59.0, the version package.json pins. Since the 1.8.0 bump it had still resolved v1.58.0's commit, so tests and CI ran on 1.58.0. The suite and the goldens pass unchanged on 1.59.0.

Not in this release: the built-in Definition File column reads only a Simulink.VariantBankCoderInfo's field. Core's Parameter and Signal schemas don't project CoderInfo.CustomAttributes.DefinitionFile into rows, so a parameter's DefinitionFile stays empty. That needs a core change.

Checks

  • npm run verify: 396 files, 7,530 tests passed, 1 skipped; boundary, version, API and leak checks OK. No golden changes.
  • I broke each feature in turn (no keyboard move, every group expanded, fold state not kept, no prefix strip, no 1×1 unwrap, top-level not winning, no focus on open); each break failed its tests.
  • Headless Chromium (gallery), with real key presses: groups open folded when they show nothing, and the focus starts on Value's box. Alt+↓ moves Value within its group and announces it. A group's box shows the whole group, a folded Other Properties keeps its field, and Escape closes the menu. Light and dark screenshots look right, with no page errors.

The 1.8.0 bump moved package.json's core devDependency to #v1.59.0 but left the lockfile resolving v1.58.0's commit (dd49527), which npm ci installs without a word: view's tests and CI have run against core 1.58.0 since. The lockfile now resolves fdbd277, v1.59.0's commit; the full suite and the goldens pass unchanged on it.
…n, and read storage class attributes as property columns

The rest of the in-MATLAB data explorer's Columns dropdown (its design's G2-G4 and G8):

- Each group's header has a toggle (a click on its name folds too), a box over the group's
  columns and "a of b". A group opens expanded when it shows a column. The window keeps each
  group's fold for every table of the storageKey, saves it nowhere, and Reset leaves it alone.
  Opening the menu writes the state down, so unchecking a group's last column does not fold it.
  The box is mixed while some columns show; on a group that shows all it hides them, on any other
  it shows them all, and Name stays shown. Other Properties has the same header; folded, it keeps
  its field, and Add unfolds it.
- Alt+Up/Down on a column moves it one place within its group (never past Name), the focus
  following it and a live region saying "<column> moved to position i of n". Opening the menu
  focuses its first column box; Escape anywhere in it closes it, back on the Columns button.
- A property column whose name the object has no top-level property of reads its storage class's
  attribute of that name (CoderInfo.CustomAttributes.GetFunction as GetFunction). A top-level
  property of the name wins whatever its value; a built-in column's name never reads one. Typed
  as CoderInfo.CustomAttributes.X, the column is X; a refused name's notice quotes what was typed.
  A binary dictionary keeps each nested object as a 1x1 object array, which is read the same.

test-integration/fixtures/cscattributes holds a text and a binary dictionary MATLAB wrote with
ExportToFile, GetSet and Struct attributes (make_csc_attributes.m, which also prints what MATLAB
reads back); a folder of its own, so no folder golden lists it. No golden changes: no other
fixture has a storage class with attributes.
@ww-mw
ww-mw merged commit 2d69336 into main Nov 17, 2026
6 checks passed
@ww-mw
ww-mw deleted the table/column-menu-groups branch November 17, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant