Skip to content

Columns menu: reorder within a group, Other Properties columns, fixed top and bottom (1.9.0) - #118

Merged
ww-mw merged 2 commits into
mainfrom
table/column-config-groups
Nov 17, 2026
Merged

ww-mw merged 2 commits into
mainfrom
table/column-config-groups

Conversation

@ww-mw

@ww-mw ww-mw commented Nov 17, 2026

Copy link
Copy Markdown
Member

Release 1.9.0, on core v1.59.0: the table's Columns menu follows the in-MATLAB data explorer's Columns dropdown.

Reorder within the group. A column moves only among the columns of its own group, in the menu and by its header. Over another group's item or header the drag shows no drop, and a drop moves nothing. The table's columns are always group by group; an order saved before this is shown regrouped, each group in its saved order.

Other Properties. A field (Enter or Add) takes any property name and shows it as a column at the table's end. Its cells come from the rows' new _props, and are empty on a row whose object has no such property: on object_props_text.sldd, fleetObject shows FleetName "east" and Count 3, and a made-up MyPropC is empty.

  • A built-in column's key or label (StorageClass, last modified by) shows that column instead.
  • A name that is no MATLAB property name, or one already shown, is refused with a notice.
  • Added columns are kept under the storageKey with their shown/hidden state, move among themselves only, are searched like the others, stay through Reset (MATLAB's D9), and are removed by their ×.

Layout. The title and Reset are at the top, Other Properties is fixed at the bottom, and only the built-in list between them scrolls. The menu is no taller than the space below the Columns button, with a 120 px floor.

Rows carry _props. stampRow adds the object's own properties that the row has no column for:

  • from a class object's property children (core's isObjectPropertyBag);
  • from a Simulink object's property bag: text, numbers, logicals, lists of those and typed scalars, printed as core's Property Inspector prints them. Nested objects (CoderInfo) and *_internal fields are left out.

They are read directly, not through toPIObject(), which cost three quarters of a 15,000-entry dictionary's open. With this change that open takes the same time as before (~165 ms).

Goldens. 95 snapshots gain _props and nothing else. With the projection turned off, the previous snapshots pass 140 of 140.

Checks

  • npm run verify: 394 files, 7,505 tests passed, 1 skipped; boundary, version, API and leak checks OK.
  • Headless Chromium (gallery): the top and bottom stay fixed while the middle scrolls, a real drag moves within a group and not across, and the dark theme looks right.
  • VS Code extension pinned to this branch: 562 of 564 unit tests pass; the 2 failures are viewPin.test.ts, which wants a tag.
  • App pinned to this branch: typecheck and 720 unit tests pass. A hidden Electron run added FleetName, Count and MyPropC and showed the values above, with no page errors.
  • The maintainer tested both hosts by hand.

Not in this release: collapsing groups, a group's tick box with its "a of b" count, Alt+↑/↓ reordering, and storage-class attribute columns.

…nd fix Reset and Other Properties around a scrolling list

The Columns menu follows the in-MATLAB data explorer's Columns dropdown:

- A column moves only among the columns of its own group, in the menu and by its header. Over
  another group's item or header the drag shows no drop and a drop moves nothing. The table's
  columns are always group by group; an order saved before this is shown regrouped, each group in
  its saved order.
- An Other Properties group takes any property name typed into its field (Enter or Add) and shows
  it as a column at the table's end. Its cells are the rows' _props of that name, empty on a row
  whose object has no such property. A built-in column's key or label shows that column instead; a
  name that is no MATLAB property name, or one already shown, is refused with a notice. Added
  columns are kept under the storageKey with their shown/hidden state, move among themselves only,
  are searched like the others, stay through Reset, and are removed by their ×.
- The title and Reset sit at the top, Other Properties is fixed at the bottom, and only the built-in
  list between them scrolls. The menu is no taller than the space below the Columns button, with a
  120 px floor.

Rows carry _props: stampRow adds the object's own properties that the row has no column for, from
a class object's property children and a Simulink object's property bag (text, numbers, logicals,
lists of those and typed scalars, printed as core's Property Inspector prints them; nested objects
and *_internal fields left out). It reads them directly rather than through toPIObject(), which
cost three quarters of a 15,000-entry dictionary's open; with this, that open takes the same time.

The goldens gain _props and nothing else: with the projection turned off, the previous snapshots
pass 140 of 140.
@ww-mw
ww-mw merged commit 2644bbc into main Nov 17, 2026
6 checks passed
@ww-mw
ww-mw deleted the table/column-config-groups branch November 17, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant