Repository navigation
Columns menu: reorder within a group, Other Properties columns, fixed top and bottom (1.9.0) - #118
Merged
Merged
Conversation
…nd fix Reset and Other Properties around a scrolling list The Columns menu follows the in-MATLAB data explorer's Columns dropdown: - A column moves only among the columns of its own group, in the menu and by its header. Over another group's item or header the drag shows no drop and a drop moves nothing. The table's columns are always group by group; an order saved before this is shown regrouped, each group in its saved order. - An Other Properties group takes any property name typed into its field (Enter or Add) and shows it as a column at the table's end. Its cells are the rows' _props of that name, empty on a row whose object has no such property. A built-in column's key or label shows that column instead; a name that is no MATLAB property name, or one already shown, is refused with a notice. Added columns are kept under the storageKey with their shown/hidden state, move among themselves only, are searched like the others, stay through Reset, and are removed by their ×. - The title and Reset sit at the top, Other Properties is fixed at the bottom, and only the built-in list between them scrolls. The menu is no taller than the space below the Columns button, with a 120 px floor. Rows carry _props: stampRow adds the object's own properties that the row has no column for, from a class object's property children and a Simulink object's property bag (text, numbers, logicals, lists of those and typed scalars, printed as core's Property Inspector prints them; nested objects and *_internal fields left out). It reads them directly rather than through toPIObject(), which cost three quarters of a 15,000-entry dictionary's open; with this, that open takes the same time. The goldens gain _props and nothing else: with the projection turned off, the previous snapshots pass 140 of 140.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.9.0, on core v1.59.0: the table's Columns menu follows the in-MATLAB data explorer's Columns dropdown.
Reorder within the group. A column moves only among the columns of its own group, in the menu and by its header. Over another group's item or header the drag shows no drop, and a drop moves nothing. The table's columns are always group by group; an order saved before this is shown regrouped, each group in its saved order.
Other Properties. A field (Enter or Add) takes any property name and shows it as a column at the table's end. Its cells come from the rows' new
_props, and are empty on a row whose object has no such property: onobject_props_text.sldd,fleetObjectshows FleetName"east"and Count3, and a made-upMyPropCis empty.StorageClass,last modified by) shows that column instead.storageKeywith their shown/hidden state, move among themselves only, are searched like the others, stay through Reset (MATLAB's D9), and are removed by their ×.Layout. The title and Reset are at the top, Other Properties is fixed at the bottom, and only the built-in list between them scrolls. The menu is no taller than the space below the Columns button, with a 120 px floor.
Rows carry
_props.stampRowadds the object's own properties that the row has no column for:isObjectPropertyBag);CoderInfo) and*_internalfields are left out.They are read directly, not through
toPIObject(), which cost three quarters of a 15,000-entry dictionary's open. With this change that open takes the same time as before (~165 ms).Goldens. 95 snapshots gain
_propsand nothing else. With the projection turned off, the previous snapshots pass 140 of 140.Checks
npm run verify: 394 files, 7,505 tests passed, 1 skipped; boundary, version, API and leak checks OK.viewPin.test.ts, which wants a tag.Not in this release: collapsing groups, a group's tick box with its "a of b" count, Alt+↑/↓ reordering, and storage-class attribute columns.