Bump to 1.31.0: a million-element array no longer becomes a million nodes - #54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases #53.
An array past the new
MAX_EXPANDED_ELEMENTS(10,000) expands into no element children, and element labels are O(1) instead of O(n) each. On the.slddthat prompted it — one 1000x1000 double — ingest goes from 1,001,276 nodes / ~690 MB / ~161 s of labelling to 1,276 nodes, 95 MB, 288 ms, and the entry still serializes back byte-identical.Minor, not patch: what children an array has is observable behaviour, even though no value changed.