Fix destructuring when tabToRemove is undefined#1196
Open
arnaudchenyensu wants to merge 1 commit intomathuo:masterfrom
Open
Fix destructuring when tabToRemove is undefined#1196arnaudchenyensu wants to merge 1 commit intomathuo:masterfrom
arnaudchenyensu wants to merge 1 commit intomathuo:masterfrom
Conversation
arnaudchenyensu
force-pushed
the
fix/tabToRemove
branch
2 times, most recently
from
9ab00cf to
c477099
Compare
arnaudchenyensu
force-pushed
the
fix/tabToRemove
branch
from
c477099 to
54e7636
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was a bug when calling
fromJSON, dockview will try toclearthe different panels and destructure an undefined variable.Type of change
Affected packages
dockview-coredockview(vanilla JS)dockview-reactdockview-vuedockview-angulardocsHow to test
I had this bug when mounting/unmounting a React root (similar to this bug #845)
Checklist
yarn lint:fixpassesyarn formatpassesnpm run genhas been run and generated files are up to dateyarn testpasses