fix(editor): initialize default page state for new blank notes - #7
Merged
Dronquavious merged 1 commit intoAug 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where non-drawing canvas tools (such as inserting images, creating text boxes, and selecting elements) are unresponsive when opening a new, blank note until an initial pen stroke is drawn.
Root Cause
When opening a new note,
readNoteBody(id)returnsnull.NoteScreenpreviously left itsenginePagesstate as an empty array ([]). BecauseInfiniteInkCanvasdoes not fireonPagesChangeduring initial mounting,enginePages.lengthremained0.This empty state caused:
applyInsertedImage) to calculate a target page index of-1(Math.min(currentPageIndex, 0 - 1)), aborting image placement.mutateOverlay) to look upenginePages[0], findingundefinedand dropping overlay updates.OverlayLayerscreen-to-page coordinate mapping to fail.Once any handwriting occurred, native drawing events triggered
ensureSingleTrailingBlankPage(), which firedonPagesChangeand synchronizedenginePages, unblocking the remaining tools.Proposed Changes
app/note/[id].tsx, updatedNoteScreeninitialization so that whenreadNoteBody(id)returnsnull(for new notes), it falls back to a default 1-pageSerializedNotebookDatastructure.enginePagesandoverlayMapare now populated immediately upon note creation, and the initial page state is passed tocanvasRef.current?.loadNotebookData().Test Plan
npm run typecheckto confirm zero TypeScript errors.