Skip to content

Fix missing PDF markup and misaligned thumbnail handwriting - #46

Merged
Dronquavious merged 2 commits into
mathnotes-app:mainfrom
Dronquavious:fix/pdf-markup-and-thumbnails-main
Nov 12, 2026
Merged

Dronquavious merged 2 commits into
mathnotes-app:mainfrom
Dronquavious:fix/pdf-markup-and-thumbnails-main

Conversation

@Dronquavious

Copy link
Copy Markdown
Contributor

Summary

  • Handwriting added with Apple Markup disappeared on import because OpenNotes drew the PDF page without its annotations. The editor, thumbnails, and exports now use a cached copy with the visible annotations drawn onto the page. The original PDF stays intact. Large exports rebuild affected pages so old previews can't hide the markup.
  • Handwriting added in OpenNotes looked oversized and shifted in PDF thumbnails because the preview used a different scale than the saved ink. The app now rebuilds PDF thumbnails from saved ink at the correct scale and keeps the PDF background and overlays. Older covers refresh automatically.

Validation

  • All 123 tests passed, along with TypeScript checking and the native PDF and thumbnail smoke tests.
  • Verified new imports, older covers, PDF export, and handwriting near the bottom of the page on a 10th-generation iPad simulator running iPadOS 27.0.
  • Confirmed both fixes on a physical 10th-generation iPad running iPadOS 27.0.1.

@Dronquavious
Dronquavious merged commit 468d0b6 into mathnotes-app:main Nov 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant