Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds standard, narrow, and compact ruled-paper presets plus a custom slider for 12–60 lines per page. Users can choose custom spacing when creating a note or change it in an existing lined note. Existing notes keep their current ruling. Thumbnails and PDF exports use the selected paper, including notes with mixed PDF and blank pages.
Uses the vendored Mobile Ink 0.3.13 source from mathnotes-app/mobile-ink#68.
Validation: OpenNotes typecheck and 76 focused catalog/export/thumbnail tests passed. A browser preview exercised the new slider and note-creation callback. The earlier preset-only native iPad test passed for creation, changing spacing, and persistence after relaunch; the updated custom-slider native test is included in the audit. A signed custom-spacing build has been installed on the iPad for user testing.
The full responsiveness audit previously stopped before measuring the workload because the hosted runner did not reach its idle threshold, including with Spotlight indexing disabled. The latest audit is running; no responsiveness budget was changed. See https://github.com/mathnotes-app/OpenNotes/actions/runs/42542449418.
Maintainability and security reviews found no remaining actionable issues. The existing editor, library screen, catalog, localization dictionaries, and native UI test files exceed 500 lines; these changes make small additions at their established boundaries, and splitting them here would enlarge the change and risk unrelated regressions.