Renames Locales Directory#1473
Open
zorkow wants to merge 4 commits into
Open
Conversation
dpvc
force-pushed
the
feature/locale_plus3
branch
from
0065ee2 to
e56940b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR renames
localesdirectory to__locales__. The main reason is that if we have thetexdirectory with all the extensions, each in a subdirectory, havinglocalesthere makes it look like it is just another extension.__locales__makes it stand out better and possibly filter it more easily. This is similar to having__mocks__directories forjest.