Skip to content

Fixed bug into mirroring in blade class #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavideOberto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed bug into mirroring in blade class #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion bladex/blade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ def apply_transformations(self, reflect=True):
# Setting thickness max is required
if self.thickness is not None:
self.sections[i].set_thickness_max(self.thickness[i])

# Setting camber max is required
if self.camber is not None and i < self.n_sections-1:
self.sections[i].set_camber_line_max(self.camber[i])
Expand Down Expand Up @@ -534,6 +534,17 @@ def mirror(self, *args, **kwargs):
else:
raise ValueError('Wrong arguments passed')

# Updating np.array with coords
point1_np = np.array([point1.X(), point1.Y(), point1.Z()])
normal_np = np.array([normal.X(), normal.Y(), normal.Z()])

# Formula to compute one shot the mirrored points w.r.t. plane
V_up = self.blade_coordinates_up - point1_np[None, :, None]
self.blade_coordinates_up = self.blade_coordinates_up - 2*np.einsum('j,ik->ijk', normal_np, np.einsum('ijk,j->ik', V_up, normal_np))
V_down = self.blade_coordinates_down - point1_np[None, :, None]
self.blade_coordinates_down = self.blade_coordinates_down - 2*np.einsum('j,ik->ijk', normal_np, np.einsum('ijk,j->ik', V_down, normal_np))


# Ax2 object identifying the plane
ax2 = gp_Ax2(point1, normal)

Expand Down
Loading