Skip to content

Counting esum - #2063

Merged
affeldt-aist merged 5 commits into
math-comp:masterfrom
lyonel2017:esum_counting
Oct 17, 2026
Merged

affeldt-aist merged 5 commits into
math-comp:masterfrom
lyonel2017:esum_counting

Conversation

@lyonel2017

@lyonel2017 lyonel2017 commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor
Motivation for this change

Provide a connection between esum and lesbegue_integrale (extracted from #2049).

Depends on #2062.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Reminder to reviewers

@affeldt-aist affeldt-aist added this to the 1.18.0 milestone Jul 30, 2026
@lyonel2017
lyonel2017 force-pushed the esum_counting branch 3 times, most recently from 4e89861 to 9db0b40 Compare August 4, 2026 15:16
@affeldt-aist

Copy link
Copy Markdown
Member

PR #2062 merged -> need rebasing

@lyonel2017

Copy link
Copy Markdown
Contributor Author

PR #2062 merged -> need rebasing

I made a rebase.

@affeldt-aist

Copy link
Copy Markdown
Member

Thanks for the rebase!

@affeldt-aist

Copy link
Copy Markdown
Member

Note that this PR has clamp but does not actually use it, it can be removed since moreover it is the target of another PR.

@lyonel2017

Copy link
Copy Markdown
Contributor Author

Note that this PR has clamp but does not actually use it, it can be removed since moreover it is the target of another PR.

This PR is now rebase on top of master.

@affeldt-aist

affeldt-aist commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

@lyonel2017 where do you use discrete_measurable_space in your developments? for the record, I would like to keep a pointer to a clear application for potential users. (A pointer inside #2116 could be enough.)

(I took the liberty to adapt naming to the rest of the library, trying to preserve consistency as much as possible still taking your proposals into account, do not hesitate to share concerns if any.)

@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Oct 2, 2026
@lyonel2017

Copy link
Copy Markdown
Contributor Author

@lyonel2017 where do you use discrete_measurable_space in your developments? for the record, I would like to keep a pointer to a clear application for potential users. (A pointer inside #2116 could be enough.)

I made a small experiment in the context of #2116 to check that the definition of expectation of #2064 and from random_variable.v are the same : expectationE. I'm not sure if this is the best approach for this proof.

@affeldt-aist affeldt-aist added experiment 🧪 This issue/PR is very experimental and removed enhancement ✨ This issue/PR is about adding new features enhancing the library labels Oct 4, 2026

@hoheinzollern hoheinzollern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above.

Comment thread classical/classical_sets.v Resolved
Comment thread theories/esum.v Resolved
Comment thread theories/esum.v Resolved
Comment thread _CoqProject Resolved
Comment thread CHANGELOG_UNRELEASED.md Resolved
@affeldt-aist affeldt-aist mentioned this pull request Oct 9, 2026
1 task done

@affeldt-aist affeldt-aist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last commit, I essentially removed the mention to measurable_space from the header (it does not seem to exist), add a bit of documentation, and use infinite_esum_cst (generalized as suggested @hoheinzollern) to simplify the proof in counting_measure.v.

@affeldt-aist

Copy link
Copy Markdown
Member

(I think that @hoheinzollern have all been addressed: thanks for the careful review!)

@affeldt-aist
affeldt-aist merged commit 6c13256 into math-comp:master Oct 17, 2026
70 checks passed
@affeldt-aist
affeldt-aist deleted the esum_counting branch October 17, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experiment 🧪 This issue/PR is very experimental

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants