Skip to content

To preserve the mathcomp CI (forward dependency) for PR#1611#1987

Open
gbdrt wants to merge 1 commit into
math-comp:masterfrom
gbdrt:unstable_20260605
Open

To preserve the mathcomp CI (forward dependency) for PR#1611#1987
gbdrt wants to merge 1 commit into
math-comp:masterfrom
gbdrt:unstable_20260605

Conversation

@gbdrt

@gbdrt gbdrt commented Jun 5, 2026

Copy link
Copy Markdown

Backward compatibility layer using Elpi.
Developed with the assistance of Claude Opus 4.8 (1M context).

Motivation for this change
Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

Developed with the assistance of Claude Opus 4.8 (1M context).

Co-authored-by: Cyril Cohen <cyril.cohen@inria.fr>
Co-authored-by: Reynald Affeldt <reynald.affeldt@aist.go.jp>
@affeldt-aist affeldt-aist self-requested a review June 8, 2026 08:14
Comment thread classical/unstable.v
Import Order.TTheory GRing.Theory Num.Theory.
Local Open Scope ring_scope.

(* Backward compatibility with math-comp < 2.6, which has no [conjFieldType]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The week following this PR, we have changed master so that it is only compatible with MathComp master (and therefore the to-be-released-soom MathComp 2.6.0), so this elpi command need not be merged anymore.

@affeldt-aist

Copy link
Copy Markdown
Member

We might not need the elpi command anymore, but do we still need the other changes then? (Sorry, I forgot... :-()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants