Repository navigation
Conversation
… it fails on data drift
Contributor
Author
|
From what I can tell, the test failure here is unrelated to the PR ( |
Contributor
Author
|
Also just noting something that was spotted when investigating this: the v2026.09.28 MP mixed phase-diagram table has 3,536 duplicate chemical-system rows, all identical. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted this issue when testing out the latest
mp-apirelease and associated MP database release.Summary
MPRester.get_entries_in_chemsys(..., property_data=[...])(default mixed thermo type) raisesKeyErrorfor any chemical system whose pre-built phase diagram contains a GNoMe entry, for API keys without GNoMe access. E.g. Cu-Se-Si (database v2026.09.28):mp-3336429(Cu3SiSe4, on the hull) is a GNoMe material (gnome_r2scan_statics,license: BY-NC).The pre-built phase diagrams (S3
objects/phase-diagrams) include GNoMe entries for every API key, butthermo.search(like all the access-controlled REST collections) does not return GNoMe docs to API keys without GNoMe access, so theproperty_datadecoration fails on the missing doc.Changes
ThermoRester.get_phase_diagram_from_chemsys(used byget_entries_in_chemsys,get_stability,the oxygen evolution helper and the MCP phase diagram tool): for keys without GNoMe access, GNoMe entries are ommited and the (mixed) phase diagram is rebuilt.
MaterialsProjectDFTMixingSchemeplaces GGA(+U)-only entries onto the r2SCAN hull including the GNoMe entries, so these are
re-referenced to the r2SCAN hull without them (
_accessible_entries).Additional details from Claude:
Scope (served
GGA_GGA+U_R2SCANphase diagrams, read from the public S3 Delta tables)v2026.09.28: 21,694 of 117,172 chemical systems (18.5%) have GNoMe entries in their served phase
diagram (
KeyErrorwithout access). 29,203 GNoMe materials, 27,977 of them on a hull.Checklist
ruff.mypy.duecredit@due.dcitedecorators to reference relevant papers by DOI (example)