Reducing complexity of implementation in order to be able to add Atlas text search token based pagination#1046
Reducing complexity of implementation in order to be able to add Atlas text search token based pagination#1046kbuma wants to merge 15 commits intomaterialsproject:mainfrom
Conversation
tsmathis
left a comment
There was a problem hiding this comment.
Not really much to say on my end, I am be curious though about the performance/execution time of this implementation vs. the parallel approach.
77913b3 to
28e74e1
Compare
…d flatten once with chain.from_iterable
|
@esoteric-ephemera @tsmathis I've addressed all outstanding comments. Ready for re-review. |
|
Nothing else to add from my end |
…ion with append + chain.from_iterable
|
|
Thanks @kbuma - added missing settings back in for this to work. Looks like this current code block only triggers on a full download from S3 |
|
Also just a note: No further changes needed on my side, will merge this after our next deployment to isolate issues we're seeing |
Summary
Major changes: