Repository navigation
Migration to a client first Single Page App - #19
Open
Bud-Macaulay wants to merge 39 commits into
Open
Bud-Macaulay wants to merge 39 commits into
Bud-Macaulay wants to merge 39 commits into
Conversation
Bud-Macaulay
marked this pull request as ready for review
November 3, 2026 09:19
Contributor
Author
|
Tagging relevant people; |
Contributor
Author
|
@t-reents - can you check that the test-suite generation makes sense - It's fairly simple, i just generate all spacegroups using Pymatgen, however it might be nicer to ensure that we are sampling all extended-bravais-lattices? My own private tests run across all of MC3D and match for all but 4 structures (due to moyo differences) - so i am fairly confident i have feature parity. |
Contributor
Author
Contributor
Author
|
2a9a1af addresses 2. |
Contributor
Author
|
2e90cf5 addresses 11 |
Contributor
Author
|
0e2a4c4 addresses 15 |
Contributor
Author
|
5a846f6 addresses 10. and 11. |
Contributor
Author
|
Example of new visualizer in 1674b6 which should be more performant. Also fixed bug in CP2k and vasp style kpoints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff will not make much sense at all since the architecture has completely changed.
Deployed to https://seekpath-web-demo.pages.dev/ as a staging URL under my personal CF account
I have added a test-suite and a npm command to run it; this ensures the resulting JSON (from the python implementation) is identical.
Things ** :
Runs on matsci-parse;
Rendering layers:
Things still to do: