Skip to content

Migration to a client first Single Page App - #19

Open
Bud-Macaulay wants to merge 39 commits into
developfrom
migrate-spa
Open

Bud-Macaulay wants to merge 39 commits into
developfrom
migrate-spa

Conversation

@Bud-Macaulay

@Bud-Macaulay Bud-Macaulay commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

The diff will not make much sense at all since the architecture has completely changed.
Deployed to https://seekpath-web-demo.pages.dev/ as a staging URL under my personal CF account

I have added a test-suite and a npm command to run it; this ensures the resulting JSON (from the python implementation) is identical.

Things ** :
Runs on matsci-parse;
Rendering layers:

  • mc-react-library (design is still unsettled but overall layout may stay somewhat similar)
    • structure upload
    • examples
    • history saver
    • accordion content
    • App header
    • Hash modals
  • mc-react-header (for the top level header)
  • BZ visualizer (pending rewrite)
  • mc-react-structure-visualizer

Things still to do:

  • 1. Check the latest vasp doc to see if i need to keep Hybrid accordion ?
  • 2. Re-add CP2K block for parsing.
  • 3. Decide if we are happy with the examples/structure upload panel, suggestion of side by side might be nicer
  • 4. Decide if we want history to be in page body or if we move it to a side panel
  • 5. Rewrite BZ Visualizer to be more performant, React-ready and work with fermisurface visualizer.
  • 6. Discuss https://seekpath.materialscloud.io/compute/termsofuse/ - almost all of this is now outdated.
  • 7. Add the JSON output - since this is the machine readable format - match current API.
  • 8. Investigate whether we can make the examples a little cleaner; perhaps there are more "pretty" examples we can use
  • 9. Wire up CI/CD for tests, deployment and what not.
  • 10. Drop old CI/CD
  • 11. Add rendered screenshots both for demonstrations in future but also for consistancy.
  • 12. Investigate cross browser rendering.
  • 13. Check if we need to do a release
  • 14. Discuss if we need to have a [ Version History accordion ]
  • 15. Add plausible and other important things to the index.html file
  • 16. consider adding a common footer element to mc-react-library

@Bud-Macaulay
Bud-Macaulay marked this pull request as ready for review November 3, 2026 09:19
@Bud-Macaulay

Copy link
Copy Markdown
Contributor Author

Tagging relevant people;

@t-reents
@giovannipizzi

@Bud-Macaulay

Copy link
Copy Markdown
Contributor Author

@t-reents - can you check that the test-suite generation makes sense - It's fairly simple, i just generate all spacegroups using Pymatgen, however it might be nicer to ensure that we are sampling all extended-bravais-lattices?

My own private tests run across all of MC3D and match for all but 4 structures (due to moyo differences) - so i am fairly confident i have feature parity.

@Bud-Macaulay

Copy link
Copy Markdown
Contributor Author

c206983 addresses 7.

c11b912 addresses 1. (although we could suggest users use a KPOINTS_OPT file for modern vasp)...

@Bud-Macaulay

Copy link
Copy Markdown
Contributor Author

2a9a1af addresses 2.

@Bud-Macaulay

Copy link
Copy Markdown
Contributor Author

2e90cf5 addresses 11

@Bud-Macaulay

Copy link
Copy Markdown
Contributor Author

0e2a4c4 addresses 15

@Bud-Macaulay

Copy link
Copy Markdown
Contributor Author

5a846f6 addresses 10. and 11.

@Bud-Macaulay

Copy link
Copy Markdown
Contributor Author

Example of new visualizer in 1674b6 which should be more performant.

Also fixed bug in CP2k and vasp style kpoints.
Addresses 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant