docs(list, menu): clarify request-activation event audience#5975
Merged
copybara-service[bot] merged 1 commit intoMay 22, 2026
Merged
Conversation
e111077
reviewed
May 21, 2026
Contributor
e111077
left a comment
e111077
left a comment
There was a problem hiding this comment.
LGTM, but I don't have review permissions anymore
asyncliz
approved these changes
May 22, 2026
Collaborator
asyncliz
left a comment
asyncliz
left a comment
There was a problem hiding this comment.
Thanks for the docs :)
copybara-service
Bot
merged commit 55576b4
into
material-components:main
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5370.
In #5370, @asyncliz (collaborator) said "I'll leave this open to fix the docs" after @e111077 (contributor) explained the intended audience: "request-activation is still documented... It's really only meant to be used by people trying to make their own list/menu/select item or if someone wants to preventDefault / stopPropagation for complex menu interactions. I think it should stay documented".
This adds that audience note to the descriptions of
request-activation:list/internal/listitem/list-item.ts:@fires request-activationJSDoc.menu/internal/submenu/sub-menu.ts:@fires request-activationJSDoc.docs/components/list.md: Events table row.docs/components/menu.md: Events table row.Per @e111077, the docs bot is still broken, so the JSDoc source and the markdown tables are updated in sync.
No behavior change. Pure docs.