[pull] main from isaac-sim:main#19
Merged
Merged
Conversation
## 1. Summary Restores scheduled changelog compilation on `develop` while preserving release-branch support by staging tracked compiler outputs independently of the package-version metadata layout. This addresses nine consecutive nightly failures since July 16. ## 2. Root cause - Scheduled runs load `.github/workflows/nightly-changelog.yml` from the default `main` branch. - `develop` now stores package versions in `pyproject.toml` and has no extension manifests, while the release branch still versions packages through `config/extension.toml`. - The main workflow named both layouts in one `git add`, so the absent extension path made the develop job exit 128 after compilation succeeded. - Auto-commit messages only inspected extension-manifest diffs, so they could not describe develop version bumps. ## 3. Test plan - [x] Reproduced the unmatched `extension.toml` pathspec in [nightly run 30070931422](https://github.com/isaac-sim/IsaacLab/actions/runs/30070931422). - [x] Compiled current `upstream/develop`; patched staging captured every tracked output and rendered 14 `pyproject.toml` version transitions. - [x] Compiled the latest release pre-bump state; patched staging captured all three `extension.toml` bumps and rendered the expected package transitions. - [x] Ran `./isaaclab.sh -p -m pytest tools/changelog/test` on `develop` (90 passed). - [x] Ran `./isaaclab.sh -f` before staging, after staging, and after commit. - [x] Confirmed no source-package changelog fragment is required for this workflow-only change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )