Repository navigation
Performance: make release runtime manifest-first and dependency-free - #43
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3593fb9d00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| vst3Url: asset('vst3Url'), | ||
| standaloneUrl: asset('standaloneUrl'), | ||
| macDmgUrl: asset('macDmgUrl'), | ||
| macVst3Url: asset('macVst3Url'), | ||
| macStandaloneUrl: asset('macStandaloneUrl'), |
There was a problem hiding this comment.
When distributionEnabled is false or distributionStatus is paused, this object still exposes every non-installer asset URL; renderRelease then enables the VST3, standalone, macOS, and checksum links solely based on URL presence. An emergency distribution pause therefore disables only the installer CTAs while leaving direct binary downloads active. Omit these URLs for paused releases or gate every download link on state.type === 'enabled'.
AGENTS.md reference: AGENTS.md:L57-L59
Useful? React with 👍 / 👎.
| element.href = RELEASE_FALLBACK; | ||
| element.setAttribute('aria-disabled', 'true'); | ||
| element.setAttribute('data-release-pending', 'true'); |
There was a problem hiding this comment.
When the manifest is unavailable, paused, or missing an optional asset, this branch marks the anchor disabled but gives it a live /releases/latest URL. aria-disabled does not prevent anchor activation, and the repository CSS only changes opacity, so users can still navigate through an apparently disabled download control to a moving release that may not match the reviewed manifest. Preserve a non-download target or explicitly suppress activation for disabled links.
AGENTS.md reference: AGENTS.md:L57-L59
Useful? React with 👍 / 👎.
| const response = await fetch(`${siteBase}/release.json`, { | ||
| cache: 'no-store', | ||
| credentials: 'same-origin', | ||
| signal: controller.signal | ||
| }); |
There was a problem hiding this comment.
Replacing fetchJson and the GitHub API resolver without updating the repository's release regression checks makes the checked-in validation tooling fail on this commit: validate-latest-release.py still requires LATEST_API/parseGitHubRelease, while validate-trial-first-pages.py requires the removed fetchJson call. These checks can no longer validate the new manifest-first contract, so update them alongside this implementation.
AGENTS.md reference: AGENTS.md:L139-L145
Useful? React with 👍 / 👎.
1 participant
Goal
Finish the static-first landing optimization by making the reviewed same-origin
release.jsonthe browser runtime authority instead of calling the GitHub Releases API on each page load.Changes
release.jsonafter the loader reaches browser idle time; remove the extra cross-origin GitHub API request.https://github.com/masarray/vst-enhancer/releases/...path for the declared version.Why
The repository contract already treats reviewed release metadata as authoritative. Loading the public GitHub API during normal page startup duplicated that source of truth, added a cross-origin request, and required significantly more JavaScript. This change reduces startup work, network dependency, privacy surface, and drift risk without changing product/release/legal semantics.
Performance impact
site-v6-core.js: 21,994 B -> 7,042 B (~68% smaller raw source).site-v6.js+experience-v4.js+site-v6-core.js) to roughly 17.0 KB raw, about 58% less overall source JavaScript.site-v6.jsloads it during browser idle.Invariants preserved
Validation expected
Existing Pages CI should run release-boundary, SEO, discovery, rendered canonical artifact, and live host verification before merge.