Repository navigation
feat(M4-P0E2C1): Studio three-MU deploy with single-owner ACK+readback gating - #346
Merged
Merged
Conversation
…io serial owner Bind existing M4MultiSvUploadTransaction to DeviceController/DeviceIoWorker with transmit-confirmed ACK gating, 5s step + 120s absolute deadline, session/boot/STOP/transport-failure cancellation, firmware capability preflight and full three-MU SELECT/readback proof. Supervisor suppresses legacy V1 auto-sync/START after explicit M4 intent; QML offers bounded Deploy 3 MU without enabling unverified START. Add deterministic session isolation regressions and engineer-facing protocol guide. No firmware hot path changes, no new CI jobs.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61310e2bc5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…load Allow Ribbon Stop, F6 and WorkflowBar Stop to synchronously cancel a staging transaction before it reaches COMMIT/SELECT, even when SV RUNNING is false. Keep priority STOP in single serial worker. Addresses Codex PR #346 P2 review; no CI workflow changes.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real Studio control-plane integration
M4MultiSvUploadTransactioninto productionDeviceControllerand the existing soleDeviceIoWorker. No added COM owner/thread/timer on firmware hot path.MULTISV-CONFIG-STAGING-V2andMULTISV-TX-LAB-PREVIEWcapabilities.commandTransmitted, exact staged offset/transaction IDs/CRC, commit hash+size+generation and all 3 firmware SHOW identity rows beforeSELECTacceptance.m4Readymeans only roster verified, NOT live signal scenario / TX verified; leave three-MU START blocked until P0E3/P0F.CI economy
One consolidated atomic commit (
61310e2bc55eb4a480441d61eec58c0d2c3b4660), no debug pushes, no extra workflow files/jobs, no redundant matrix expansion. Run the repo's existing exact-head Qt/session/Windows packaging and firmware gates once; use job logs only if a check fails. No physical 12,000fps or external PTP traceability claim.Next after this gate
P0E2C2/P0E3: 3 separate
SVSTREAM CFGscenarios with board readback/adoption and verified group START; P0F physical capture. Keep M3.H.3 stable and V1 wire untouched. Tracks #333.