Skip to content

feat(M4-P0D1): isolated atomic 4I4V waveform banks for MU1/MU2/MU3 - #340

Merged
masarray merged 3 commits into
mainfrom
feat/m4-p0d1-isolated-mu-banks
Oct 25, 2026
Merged

masarray merged 3 commits into
mainfrom
feat/m4-p0d1-isolated-mu-banks

Conversation

@masarray

Copy link
Copy Markdown
Owner

P0D1 — Three independent atomic 4I+4V signal/setpoint banks

One bounded M4ThreeSvSignalBanks object owns three separate SvLiveSignalBank instances. Each stream's 8 channels, phase angles, frequency, quality, waveform shape and generation commit atomically and independently, without three workers or any heap allocation. Reuses the existing production four-buffer reader-pinning semantics.

Tests

  • Initial all slots default/zero generation
  • MU1=1234, MU2=5678, MU3=-321 counts in DC mode, with independently chosen voltages/quality
  • Iterate selected GUI page in arbitrary order; each slot's waveform matches only its own state
  • Edit MU2 phase/quality and prove MU1/MU3 states and generations remain unchanged
  • Validate bad slot and invalid phase rejection with no partial mutation

Scope is intentionally host-side signal storage contract. P0D2 will connect per-stream atomic SVSTREAM serial commands and firmware readback to these banks after P0C2B PR #339 publishes three canonical SV packets. P0E binds Studio Table/Waveform/Phasor pagination to these same slots. No M3.H.3 release artifact changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T20:52:29.879948Z 5e620db PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit 7ee7ad3 into main Oct 25, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant