Skip to content

FAT ctlModel Write: compact Material editor and reconnect-safe one-shot confirmation - #713

Merged
masarray merged 12 commits into
fix/fat-integrated-quality-attention-20261022from
staging/ctlmodel-write-live-guard-20261023
Oct 23, 2026
Merged

masarray merged 12 commits into
fix/fat-integrated-quality-attention-20261022from
staging/ctlmodel-write-live-guard-20261023

Conversation

@masarray

Copy link
Copy Markdown
Owner

Scope

Narrow follow-up to existing FAT integration #679. Branch created from exact FAT 88ac63e84a7cee7a7ed45e61043dfc8d914cb1be. No production engine lock, SMV, SSOT, Command Dock, Browser multi-DA, runtime service, IP Wizard or Control sequence change.

  • Dedicated ControlModelWriteWindow now presents a compact inline Name | Value ctlModel combo, preselected only after live Read, with registry Material Edit/Refresh/Close icons, stable 94px Write label and scrollable diagnostic details under a pinned footer.
  • Guard read evidence to exact LiveDiscoveryModel identity and LiveValues.Association. Reject stale async inspection after reconnect. Recheck lease and requested option after operator confirmation, before native dispatch.
  • Require an explicit OK/Cancel confirmation, default Cancel, showing IED, exact DA, verified current model and target. No Operate, generic CO Write or automatic retry introduced; existing native expected-value comparison and readback retained.
  • New XAML/guard contract tests; update prior commissioning regression for enhanced fixed Write label and Material glyph.

Safety / gating

DRAFT — NOT MERGEABLE UNTIL exact-head Build, R7, reference/P0 checks and Windows WPF/DPI review are green. Physical IED Write not executed or claimed. FAT #679 remains the canonical integration gate; no direct main merge. Parallel Write PR #710 is diverged and touches separate Browser editor files; this narrow change deliberately avoids its paths.

Copy link
Copy Markdown
Owner Author

Source integration checkpoint / CI truth — 2026-10-23

Current staging HEAD 0fd88f1f6fa6bbab9b9a02779982b74375018fe5; preserved FAT 466f1213988ce5f468d49f7de027daa7e1e2a272 as second parent, stage e575869c as first parent; no force push. Compare FAT→stage ahead=11 behind=0, exact four changed paths: ControlModelWriteWindow.xaml, .xaml.cs, tests/ARSAS.Tests/ControlModelWriteAcceptanceTests.cs, tests/ARSAS.Tests/P109QCommandDockCommissioningRegressionTests.cs. Earlier staging lifecycle test touched a concurrent FAT file, but it has been reconciled by retaining FAT's own correction; not included in resulting tree diff.

Validation: First staging Build clean-room source guard found one reference-app name in XAML comment; repaired. Compiled Windows Build solution and 24/24 pinned engine tests PASS at earlier 54a5696f, 2827/2833 ARSAS tests PASS; all six failures were identical to pre-existing FAT SG7/Control checks (five pinned-engine prefixed-LN admission expectations, one outdated lifecycle assertion). Stage source test introduced here no longer failed. FAT integration thread subsequently fixed fail-closed SG7 tests and native gate in 83e38201, preserved in our merge tree. Last exact staging CI Build for 0fd88f is pending (39967421963); no green certification, Windows DPI screenshot, physical relay test, merge or downloadable SHA256-qualified EXE yet. PR remains draft, target FAT not main; producer engine lock remains 9c7cb40364023a7b217e5ec31ab3105ba90142eb.

Parallel FAT now advanced to e50bd748... with static report-projection tests only, so revalidate up-to-date ancestry just before merge. Do not merge until exact SHA Build/R7 and safety acceptance all pass.

@masarray
masarray marked this pull request as ready for review October 23, 2026 21:52
@masarray
masarray merged commit 7a2d911 into fix/fat-integrated-quality-attention-20261022 Oct 23, 2026
4 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-23T21:52:10.351785Z 575cca8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant