Repository navigation
IED Browser: ARSAS-specific IEC 61850 navigation order (UI-only) - #685
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8557114659
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| projection.Reset(roots); | ||
| Assert.Equal( | ||
| ["GOOSE", "Reports", "Setting Groups", "Files", "DataSets", "Data Model"], | ||
| ["Reports", "DataSets", "Data Model", "Files", "GOOSE", "Setting Groups"], |
There was a problem hiding this comment.
With this new order, P0BrowserRcbEnabledTruthTests.VirtualTreeStartsWithExactlySixCollapsedCategories still asserts GOOSE, Reports, Setting Groups, Files, DataSets, Data Model at lines 126–127. Because that test is included by the default test-project glob, every full ARSAS.Tests run now deterministically fails its Assert.Equal; update that existing assertion to the same order as this test.
AGENTS.md reference: AGENTS.md:L215-L219
Useful? React with 👍 / 👎.
ae5cbca
into
fix/fat-integrated-quality-attention-20261022
IEC 61850 IED Browser — independent ARSAS category navigation (UI-only)
Requested visible order: 1. Reports; 2. DataSets; 3. Data Model; 4. Files; 5. GOOSE; 6. Setting Groups.
Safety scope: exactly two files touched (
Models/IedBrowserPresentation.csandtests/ARSAS.Tests/IedBrowserPresentationTests.cs). Moves the existing six lazy category roots into the new visual order without changing their category keys, LD/LN/DO/DA topology, model provenance, right-side detail projection, selected tree route, MMS/IEC 61850 services, RCB, controls, SV/PTP, native bridge, production engine lock, or UI style resources. The Data Model subtree lambda is unchanged byte for byte. Test locks both visible labels and stable keys.Context: branch is based on #679 FAT checkpoint
721cb714588a7c7a0b6f358d0d0001cd190ebe24, not legacymain. This is an independent UI decision. The IEC 61850 data/service model defines equipment information and services, not the visual order of an engineering application's navigation categories. No operational behavior or third-party visual assets are changed.Acceptance: Validate exact diff and regression, Windows CI, then merge into #679 only with SHA guards. Do not modify ARIEC61850 staging-to-main PR #192 or automatic consumer engine pins. No claim of physical FAT acceptance.