Skip to content

M2.14 GUI: exact operator Explorer, Diagnostics and Command Dock icons - #583

Closed
masarray wants to merge 1 commit into
fix/m214-bound-goose-and-tapchg-evidence-20261015from
fix/m214-operator-contours-20261015
Closed

masarray wants to merge 1 commit into
fix/m214-bound-goose-and-tapchg-evidence-20261015from
fix/m214-operator-contours-20261015

Conversation

@masarray

Copy link
Copy Markdown
Owner

Exact operator SVG contours — next child of #582

User provided three precise Material contour paths for IEC Explorer (topology/network), Diagnostics (monitor/inspection) and Command Dock (power). This PR places those 960-unit coordinates unchanged in the existing WPF App.xaml Geometry registry, rebinds exactly three UI Path elements, and adds geometry + single-glyph regression. GOOSE intentionally retains the wireless contour, not an Explorer duplicate. No font blobs or new renderers.

Base: Draft PR #582, its GOOSE SCL fallback, active ST DataSet parent evidence and actual assembly-version title remain unchanged. Existing TabControl indices, navigation click handlers, monitoring session, GI/control safety, pinned engine and main are untouched. Navigation reordering to 9 destinations including a real SMV workspace requires a separate tested routing change, not a deceptive visual reorder.

Require Windows exact-SHA full regression and subsequent physical UX acceptance.

Copy link
Copy Markdown
Owner Author

Exact-SHA Windows CI PASS — final layered icon + Browser regression checkpoint. PR #583 756de98a2bb0e70bf4f88199617c165632986ddb, direct child of #582 38ad98f74c97. Build ARSAS #38708551263: 2,009/2,009 ARSAS, 19/19 pinned engine, 9/9 native CTest, 6/6 packaged managed; portable smoke and sealed Windows artifact passed. Artifact ARSAS-win-x64-portable-single-exe ID 11959742039 is exact HEAD, unexpired. All 10 of 10 workflows success.

Changes on top of #582: operator-provided exact SVG contours for Explorer (topology), Diagnostics (inspection), and Command Dock (power); GOOSE retains wireless. No behavior/routing changes, no external fonts, no main or engine-pin changes. GOOSE SCL control-directory fallback, ST TapChg typed parent and actual assembly-version title remain from #582.

Not physically accepted: GOOSE live subscriber frames and actual GoCB/APPID directory on physical BCUGE, TapChg parent from current relay Report, quality raw MMS flags (Report vs explicit Read), pre-Read SG value semantics, exact CF units, true 9-destination navigation including SMV, explicit safe GI. These are real acceptance requirements, not cosmetic CI-green assumptions. Coordinate any further changes from #583 HEAD; predecessor PRs all Draft.

Copy link
Copy Markdown
Owner Author

Field feedback continuation: full-row fast navigation + full selected-DO explicit Read. New downstream draft PR #584 at 5691e3fed31cb5dbc304ac54045759540006d362 is a direct child of your exact #583 head 756de98a2bb0 and leaves prior GOOSE SCL binding, TapChg, title version and operator SVG work unchanged. It adds single-click row expansion to the existing virtual Objects/Data detail grids (button-origin guarded; no duplicate double-click toggles), and when a DO in an LN detail page is chosen, explicit Read targets every model-authorized safe-FC leaf of that exact DO rather than implicitly sweeping LN or only projecting stVal. No automatic read, CO/control write, GI, cyclic MMS, engine pin changes or merge to stable. Three read-target regression cases included. Windows Build #38710325989 running; real relay acceptance remains outstanding.

Copy link
Copy Markdown
Owner Author

Exact-SHA CI verified GREEN on downstream PR #584, head 5691e3fed31cb5dbc304ac54045759540006d362, based on unchanged #583 756de98a2bb0. Windows Build ARSAS #38710325989 SUCCESS with 2,012/2,012 ARSAS app, 19/19 pinned ARIEC, 9/9 native CTest, 6/6 packaged managed, and exact-head portable artifact ARSAS-win-x64-portable-single-exe 11960342507 (not expired). All 10/10 workflows success. Full-row single-click Objects/detail expansion is local navigation only; selected detail DO → explicit Read now enumerates every model-proven safe FC leaf of that exact DO via the existing isolated read service, without changing Read All, Report ingest, source identity, CO writes/GI, engine pin, GOOSE handling, or public stable. Three targeted read-plan tests included. Physical Windows UI/BCUGE/ZIV acceptance still pending; don't merge stable/main.

Copy link
Copy Markdown
Owner Author

D13 source + regression semantic audit — KEEP OPEN: navigation indices and SMV page changed

Original #583 head 756de98a2bb0e70bf4f88199617c165632986ddb is ancestor of protected integrated RC 817c3910e8223fa2ac531a4426ada5d2d4bbbe50 (ahead1363/behind0). Inspected all three original paths old→RC:

  • App.xaml 4f1233e9cb0d5788f0a1d7455c69327dfa98c9cf → d2fe57403412db2c076e944470ae6c0bb9540186: Material/Operator icon registry evolved.
  • MainWindow.xaml 3ae178e957de02adf22fce87214240677cc1c940 → ee28dfe80e011740f72d114522f4311f8d852879: new navigation layout evolves original icon placement.
  • tests/ARSAS.Tests/MaterialIconConsistencyTests.cs f663cc37ad343d39d825e38243fd0a1165679e26 → 4291628ff65bd7bdebb340297004aa47111be5f5: all 8 original test method names and 52 original Assert statement lines retained, but original [InlineData] scenarios changed materially. In M2.14 GUI: exact operator Explorer, Diagnostics and Command Dock icons #583 Explorer was Tag 0, Live Tag 1, Diagnostics Tag 5, IED Browser Tag 7; in RC Explorer Tag 1, IED Browser Tag 0, Diagnostics Tag 7, and new NavSmvButton Tag 5 is introduced. Navigation glyph/Tag parity remains locally tested, but exact historic navigation order is not preserved. “All asserts retained” alone is insufficient to close this.
    Disposition KEEP M2.14 GUI: exact operator Explorer, Diagnostics and Command Dock icons #583 OPEN for GUI/navigation owner acceptance of intentional IED Browser-first page order, SMV integration, and icon/material provenance. Avoid restoring old XAML/Tag assignment by cherry-pick; would misroute accepted navigation and interfere with SMV. Historic branch/source preserved. No edits to RC, main, stable or other owner lanes.

Copy link
Copy Markdown
Owner Author

D14 source+regression parity audit — CLOSE UNMERGED, retain exact historical evidence

Historical #583 head 756de98a2bb0e70bf4f88199617c165632986ddb is an ancestor of protected RC 817c3910e8223fa2ac531a4426ada5d2d4bbbe50 (ahead1363 / behind0). Three changed paths manually inspected old→RC, not ancestry-only:

  • App.xaml blob 4f1233e9cb0d5788f0a1d7455c69327dfa98c9cf → d2fe57403412db2c076e944470ae6c0bb9540186: original single operator Material geometry resources OperatorIecTopologyIcon, OperatorDiagnosticsIcon, OperatorCommandDockPowerIcon, OperatorAddIedIcon, OperatorNtpServerIcon and MaterialIconGlyph all retained exactly once. Resource file grew with unrelated newer UI.
  • MainWindow.xaml blob 3ae178e957de02adf22fce87214240677cc1c940 → ee28dfe80e011740f72d114522f4311f8d852879: exact one of each original operator glyph binding, NavGooseButton, CommandPanelExpander; eight NavButton_Click bindings retained. MaterialIconGlyph style usages evolved (22→21), so not claiming whole-file byte identity; original invariants evaluated by corresponding tests.
  • tests/ARSAS.Tests/MaterialIconConsistencyTests.cs blob f663cc37ad343d39d825e38243fd0a1165679e26 → 4291628ff65bd7bdebb340297004aa47111be5f5: all 8 historical regression method names still present; every one of 52 historical Assert lines exactly retained. Covers Material geometry and uniqueness, nav tags+click handlers, Command Dock, Add IED dynamic buttons, Industrial P2 icon content, workstation commands, NTP toggle, Apache-2.0 icon provenance. Canonical RC tests added assertions rather than losing original contract. Integrated RC full Windows CI and SCL have passed in prior verified D13 draft safety RC rehearsal: GOOSE/SGCB + detached Control + post-Write dual-epoch fence #755 combined candidate; this is NOT new RC integration or real-device acceptance.

Unique delta: no uncarried historical operator-icon function/test known; newer GUI changes are not reverted. Scope: presentation and icon geometry ONLY; no MMS, GOOSE, SGCB, RCB, Write or native control change. Close this stale ancestor PR unmerged purely as historical tracker. Retain branch and source; #599 RCB visual, #570 phasor, #606 GOOSE and #615 Command remain separately OPEN. No stable/main/RC merge, no physical FAT claim.

@masarray masarray closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant