Skip to content

P8 C264: center editable IED IP and align Fault Records select-all - #504

Closed
masarray wants to merge 4 commits into
fix/501-sntp-header-ux-heartbeatfrom
fix/504-c264-ip-fault-checkbox-alignment
Closed

masarray wants to merge 4 commits into
fix/501-sntp-header-ux-heartbeatfrom
fix/504-c264-ip-fault-checkbox-alignment

Conversation

@masarray

Copy link
Copy Markdown
Owner

P1 — C264 native WPF field alignment (isolated implementation)

Base: exact verified cumulative ARSAS #501 HEAD 34d8f55f499be94cc49539ba632aafa6efdef105. Cross-reference the audited plans: #502 and #503. This is code, unlike those documentation-only PRs.

  • IED IP: center ComboBox display and explicitly center the real editable PART_EditableTextBox on Loaded; preserve OS/WPF theme template, saved/recent IP bindings, validation and focus.
  • Fault Records: remove the inherited 9px insets only in Get checkbox column, aligning tri-state header and row checkboxes by shared centered column geometry; preserve all other column padding.
  • Add C264FieldAlignmentRegressionTests contracts that assert both modes, scoped styles, retained bulk-selection semantics, no template rewrite, and unaffected text-cell styling.

Safety boundaries: no modifications to ARIEC61850 pin, IED controls, report acquisition, static DataSet, Npcap, GOOSE, SNTP, CI guard, release, or main. Draft: no Windows CI or DPI visual acceptance has yet been claimed. Must qualify on exact HEAD and user screenshot at 100/125/150% scale. Other defects (typed structured FCD and same-host GOOSE adapter classification) remain in planned P2/P3 follow-on PRs.

Copy link
Copy Markdown
Owner Author

Exact-head CI qualification — 2026-10-10

Commit f90f4697fb1ee607bb5500119f6b5298ce01879f (P1 only, four files, branch exactly 4 commits ahead / 0 behind #501 baseline).

  • Build ARSAS Windows x64: SUCCESS. Exact SHA checkout, pinned-engine resolution, solution compile, regression tests, portable x64 publish, executable smoke and artifact upload succeeded.
  • Portable single EXE artifact: ARSAS-win-x64-portable-single-exe.
  • Merge Execution Guard, Golden Budget Lock, Golden Provenance, and Repeat-Run Stability: SUCCESS.
  • Mainline Readiness: expected CLOSED/FAIL, because independent R10 physical authority is not approved. Do not disable or weaken gate.
  • Field trial still required: center IP editor and Fault Records header/row checkbox at 100/125/150% Windows scaling; verify no regressions to recent-endpoint typing and tri-state bulk selection. P2 typed report completeness and P3 GOOSE same-host NIC selection are outside this PR.

This PR stays DRAFT. No merges, engine changes or release changes.

Copy link
Copy Markdown
Owner Author

Disposition: Superseded — administrative consolidation of a verified commit-ancestry milestone, not a merge into main or physical acceptance.

Canonical replacement: #543 (head 6285867780b8ea79c231d72a3819e9e5f99748d2; stays OPEN for staged integration). This PR head f90f4697fb1ee607bb5500119f6b5298ce01879f is an exact Git ancestor of #543 head: GitHub compare old-head...canonical-head = ahead, ahead=233, behind=0.

Unique delta: C264 IP dialog alignment and Fault Records select-all layout; 4 changed files, including tests/ARSAS.Tests/C264FieldAlignmentRegressionTests.cs. No original commits from this PR are omitted from #543's commit ancestry; the original branch and historical patch/tests remain recoverable. The final tree's semantic equivalence and physical qualification are not claimed by ancestry alone: these are follow-up requirements at the canonical tip.

Safety: Close only the redundant intermediate PR conversation, do not delete any branch. No code edits, no engine repin, no change to main, stable v1.6.42, checksums or safety/CI gates. This particular PR is not the remaining integration gate.

Follow-up: Revalidate the accepted compact IP-connect UX on the final integration candidate; keep cross-thread IP-form redesign independent. Track unfinished acceptance and missing behaviors via #543 or the later authoritative integration/qualification workstream; do not merge #543 to main without required gates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant