Repository navigation
feat(pr-body): fail a PR from a generic claude/project-thread-* branch - #53
Merged
Merged
Conversation
A new `branch` job in the reusable pr-body workflow fails when the head branch matches the `deny-branches` ERE (default ^claude/project-thread-), so a session's generic branch name never reaches review. The devkit gets it now through pr.yml; consumers on their next bump. Tested: actionlint; the check's shell against claude/project-thread-16bz5x (denied), fix/bump-consumers-missing-token and claude/skills-lock (allowed); docs-lint Cost: n/a (no measured figure in this cloud session) Co-Authored-By: Claude <noreply@anthropic.com>
…vention Tested: actionlint Cost: n/a (no measured figure in this cloud session) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: a PR opened from a generic session branch like
claude/project-thread-16bz5xnow fails CI with a message pointing to the project's convention,claude/<issue-number>-<short-kebab-slug>(e.g.claude/47-bump-consumers-token). The rule lives in the reusablepr-body.ymlas a newbranchjob, so the devkit gets it now throughpr.ymland every consumer on its next devkit bump.claude/project-thread-16bz5x(denied),fix/bump-consumers-missing-tokenandclaude/skills-lock(allowed); docs-lintWhat changed
.github/workflows/pr-body.yml: adeny-branchesinput (ERE, default^claude/project-thread-, empty turns it off) and thebranchjob that fails a matching head branch.docs/4-reference_workflows.md: the input's row.To make it blocking rather than just red, add
branchto the required checks in.github/rulesets/main-rule.json(ruleset-sync); left out here so it doesn't block open PRs that already carry such a name.