run marimo and init containers as the same user#9
Open
bittrance wants to merge 2 commits intomarimo-team:mainfrom
Open
run marimo and init containers as the same user#9bittrance wants to merge 2 commits intomarimo-team:mainfrom
bittrance wants to merge 2 commits intomarimo-team:mainfrom
Conversation
Collaborator
|
A bit of concern this will break fuse, but stricter permissioning is ideal! Thanks! Will play around with this |
We just assume that user 1000 is the correct default user; you can always override the user if you provide a custom image.
The risk of misspells leading to an incorrectly passing test is generally small.
Contributor
Author
|
@dmadisetti Hm, fuse 🤔 . Also, I learned yesterday that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current default setup will have git-clone produce a worktree owned by root while marimo is running as uid 1000, which means that the user cannot edit it via the UI. This PR sets the default runAsUser for the marimo and all init containers to 1000 and allows overriding the value.