fix: reject duplicate database opens - #319
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlite3_open_v2sqlite3_open_v2failsNitroSQLite.native.open()pathThe current connection identity remains
dbName. Opening the same filename from a differentlocationis therefore rejected explicitly instead of silently rerouting the first connection.Closes #306.
TDD evidence
RED on
main:no such table: ConnectionMarkerGREEN: both focused tests pass against the rebuilt iOS app, and the original connection still returns its marker row.
Verification
:react-native-nitro-sqlite:assembleDebug: succeeded for all configured ABIsbun typecheckbun lintbun sqlite buildgit diff --checkExisting test-runner limitation
bun sqlite test --runInBandexits during Jest configuration before collecting tests because React Native 0.85 moved its preset to@react-native/jest-preset. This is reproducible on unchangedmain; the native harness suites above exercise the changed behavior.