fix: render points sharing one date - #131
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
Collaborator
|
3 year old issue :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
When the first and last timestamps are equal, X normalization divides by zero. The resulting NaN causes getPointsInRange to discard every point before path creation. Even after normalizing the shared timestamp, the one-pixel sampler selects only the first point, leaving Skia with a move command but no drawable segment.
The patch maps the shared timestamp to the center of the range, rejects non-matching timestamps from an explicit zero-duration range, and preserves all same-date values at that X coordinate. The existing behavior for different dates that merely floor to one canvas pixel remains unchanged.
Validation
Using the repository Node.js version (22.20.0):
Fixes #86