Update WebViewJavascriptBridgeBase.m#371
Open
wcgCoding wants to merge 1 commit intomarcuswestin:masterfrom
Open
Update WebViewJavascriptBridgeBase.m#371wcgCoding wants to merge 1 commit intomarcuswestin:masterfrom
wcgCoding wants to merge 1 commit intomarcuswestin:masterfrom
Conversation
I found the reason. If responseCallback is NULL, it will be crashed.The reason for this is that the method of using reset is incorrect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If responseCallback is NULL, it will be crashed.The reason for this is that the method of using reset is incorrect.
Before your create your PR:
Please add tests for any new or changed functionality!
Tests/WebViewJavascriptBridgeTests/BridgeTests.mmake testand make sure your test is passingThanks for improving WebViewJavascriptBridge!
Cheers,
@marcuswestin