Open
Conversation
Add var _ Interface = (*Type)(nil) assertions to catch interface drift at compile time rather than runtime. Covers all 13 interfaces: Agent (3 impls), Provider (3 impls), Reader (4 impls), CommandRunner (2 impls across agents and tmux packages), and cross-package budget/ snapshots contracts in providers/contracts_test.go. Nightshift-Task: api-contract-verify Nightshift-Ref: https://github.com/marcus/nightshift Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
var _ Interface = (*Type)(nil)compile-time assertions across 13 files covering all 13 interfaces and 17 implementationsproviders/contracts_test.go: Claude/Codex/Copilot implementingbudget.*andsnapshots.*interfaces (7 assertions)TestCodexAgent_ImplementsAgentInterfacenow covered by compile-time checkTest plan
go build ./...passes — all assertions compilego test ./internal/providers/ ./internal/agents/ ./internal/integrations/ ./internal/tmux/— all tests passNightshift-Task: api-contract-verify
🤖 Generated with Claude Code
Automated by nightshift