feat: Add endpoints to get/update management permissions on IdP, and delete mapper to IdP #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kevin-Bannier
requested review from
marcospereirampj and
ryshoooo
as code owners
delete mapper to IdP
Kevin-Bannier
force-pushed
the
feature/add-idp-endpoints-permissions
branch
from
7863467 to
fe39ad3
Compare
Collaborator
|
Thanks a lot for the contribution :) Overall looks good, but could you add unit tests for these new endpoints? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 3 methods to reach endpoints about IdP: