Update NuGet deps & enable OIDC auth in workflows - #200
Merged
Merged
Conversation
Updated Microsoft.AspNetCore.OpenApi, Swashbuckle.AspNetCore.* and SimpleAuthenticationTools.Abstractions to latest patch versions in all .csproj files. Replaced static NuGet API keys with OIDC-based authentication using NuGet/login@v1 in publish.yml and publish_swashbuckle.yml workflows, including id-token: write permission. Applied minor whitespace and formatting fixes in workflow files. No functional code changes outside dependency and CI/CD updates.
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to patch dependency updates and a correctly configured OIDC-based NuGet publishing flow with no functional library code changes.
Pull request overview
Updates package dependencies and modernizes the NuGet publishing pipelines by switching from static API keys to OIDC-based trusted publishing, aligning the repo’s CI/CD with current NuGet.org security guidance while keeping runtime behavior unchanged.
Changes:
- Bumped
Microsoft.AspNetCore.OpenApi,Swashbuckle.AspNetCore.*, andSimpleAuthenticationTools.Abstractionsto newer patch versions across library and sample projects. - Updated NuGet publish workflows to use
NuGet/login@v1(OIDC) withid-token: write, and publish using the temporary API key output. - Removed an unused
using System.Xml.Linq;from theNET10_0_OR_GREATERcompilation branch.
File summaries
| File | Description |
|---|---|
| src/SimpleAuthentication/SimpleAuthentication.csproj | Patch-version bumps for OpenApi (net9/net10) and Abstractions dependency. |
| src/SimpleAuthentication/OpenApi/AuthenticationDocumentTransformer.cs | Removes an unused System.Xml.Linq using in the NET10+ branch. |
| src/SimpleAuthentication.Swashbuckle/SimpleAuthentication.Swashbuckle.csproj | Updates Abstractions and Swashbuckle SwaggerGen patch versions. |
| samples/MinimalApis/Net8JwtBearerSample/Net8JwtBearerSample.csproj | Updates Swashbuckle.AspNetCore patch version. |
| samples/MinimalApis/JwtBearerSample/JwtBearerSample.csproj | Updates OpenApi + SwaggerUI patch versions. |
| samples/MinimalApis/BasicAuthenticationSample/BasicAuthenticationSample.csproj | Updates OpenApi + SwaggerUI patch versions. |
| samples/MinimalApis/ApiKeySample/ApiKeySample.csproj | Updates OpenApi + SwaggerUI patch versions. |
| samples/Controllers/JwtBearerSample/JwtBearerSample.csproj | Updates OpenApi + SwaggerUI patch versions. |
| samples/Controllers/BasicAuthenticationSample/BasicAuthenticationSample.csproj | Updates OpenApi + SwaggerUI patch versions. |
| samples/Controllers/ApiKeySample/ApiKeySample.csproj | Updates OpenApi + SwaggerUI patch versions. |
| .github/workflows/publish.yml | Switches NuGet publish auth from static API key to OIDC (NuGet/login@v1) and adds id-token: write. |
| .github/workflows/publish_swashbuckle.yml | Switches NuGet publish auth from static API key to OIDC (NuGet/login@v1) and adds id-token: write. |
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Microsoft.AspNetCore.OpenApi, Swashbuckle.AspNetCore.* and SimpleAuthenticationTools.Abstractions to latest patch versions in all .csproj files. Replaced static NuGet API keys with OIDC-based authentication using NuGet/login@v1 in publish.yml and publish_swashbuckle.yml workflows, including id-token: write permission. Applied minor whitespace and formatting fixes in workflow files. No functional code changes outside dependency and CI/CD updates.