Rename Mask Blur to Mask Spacer and narrow it to 2-6% - #885
Merged
Conversation
The control is the sigma of the mask's blur, but the number reads backwards from one: a thin spacer makes the mask track the image more closely, so it cancels more of it, and the print gets flatter (reduction) or blooms (increase). Labelling that "Mask Blur" promised the opposite. "Spacer" is the darkroom object that sets the unsharpness and carries no such promise. Measured per octave on a real Ektar scan at g=+0.5: 1% attenuates every band coarser than 8px to 0.5-0.76 and the global spread to 0.53x, which is a plain range scale plus a little of what Lab Sharpening already does at 0.5-3.0px. The bottom of the old range was Grade wearing a different label, so the floor goes to 2%. The top goes to 6% since 8% left everything under 64px above 0.93. The plane helper now clamps to both ends, not just the floor, so a value saved outside the new range cannot render wider than the slider can show. mask_blur -> mask_spacer is a KEY_RENAMES entry: the field shipped in a merged PR, so saved edits and sidecars carry the old name even though no release does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contrast mask's radius control is renamed and its range tightened. Nothing about the operator changes.
Why the name
The slider is the sigma of the mask's blur, but the number reads backwards from a blur radius. A thin spacer makes the mask track the image more closely, so it cancels more of it: the print goes flatter at positive gamma and blooms at negative gamma. "Mask Blur" promised the print would get softer as the number went up, and the opposite happens. The spacer is the physical sheet that sets the unsharpness in the darkroom and it carries no such promise.
Why 2-6%
Measured per octave on a real Ektar scan, ratio against unmasked:
At 1% every band coarser than 8px collapses to a flat 0.5, which is a plain range scale plus a little of what Lab Sharpening already owns at 0.5-3.0px. The bottom of the old range was Grade under another label, so the floor moves to 2%. At 8% nothing under 64px moves at all, so the top moves to 6%.
The plane helper now clamps both ends rather than only the floor, so a value saved outside the new range cannot render wider than the slider can display.
Migration
mask_blur->mask_spaceris oneKEY_RENAMESentry. The field shipped in a merged PR but no release, so saved edits and sidecars can carry the old name.Test
make allgreen: 4279 passed, 8 skipped. Includes a new test that a save under the old key still loads.