Repository navigation
Fill the man page version at build time and refresh docs - #80
Merged
Merged
Conversation
The man page header had a hardcoded Version 1.4.0. Use an @Version@ placeholder that just manpage replaces, defaulting to the latest git tag. goreleaser passes its own version to the hook, so release builds get the release version. The generated mdview.1 stays untracked. Add the missing -o and -b options to the SYNOPSIS, make the option spelling consistent, and describe flag placement and temp file cleanup. In CLAUDE.md, drop the mise.toml reference (the file is not tracked), document the placeholder rule, and record how to find and update the vendored mermaid.min.js version. Closes #71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mdview.1.mduses an@VERSION@placeholder instead of the hardcoded1.4.0.just manpage [version]replaces the placeholder. The default isgit describe --tags --always. The goreleaser hook passes{{ .Version }}, so the man page gets the release version (checked withgoreleaser build --snapshot:Version 1.9.0-SNAPSHOT-ec5f430).-oand-b. Option spelling is consistent, and the man page describes flag placement and temp file cleanup.CLAUDE.md: removes themise.tomlreference, documents the placeholder rule, and records how to find and update the vendored Mermaid version. The stale "no test files" statement was fixed in Embed images by walking the AST instead of rewriting source #74..github/copilot-instructions.mdis also out of date (Go 1.21.1, Make, the old markdown library). That is not part of this issue.Closes #71