Repository navigation
Conversation
--interpolation_use_gpx_start_time places the GPX from the start of the video instead of by the video's GPS clock. It skipped reading the clock altogether, and with it the clock's rate, so a timelapse got its GPX laid out at 1x: a 5 s, 30x timelapse got 157 s of GPX, and distance sampling picked 5 frames along its first 12 m instead of 148 along the 1.4 km route. The clock is now read in that mode too, and placed at the start of the GPX, so that only its rate is used. A video that is not a timelapse has a rate of 1, and is placed as before. The coverage check raises when the clock a track was placed by says that the track misses the video. A clock placed at the start of the GPX says nothing of the kind, so a track placed in that mode still only warns, as it did when it had no clock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
--interpolation_use_gpx_start_timeskips reading the video's GPS clock, and with it the clock's rate (#849), so a timelapse gets its GPX laid out at 1x. Distance sampling a 5 s, 30x GoPro MAX timelapse picks 5 frames along the first 12 m of its 1.4 km route.Changes
_check_coverage()raises only when the clock a track was placed by says that the track misses the video. A clock placed at the start of the GPX says nothing of the kind, so in this mode a miss still only warns, as it did before.Verification
mypy,ruff check,ruff format --checkandusort diffare clean.With #851, which drops
offset_timefromVideoSyncOption:test_gpx_start_time_only_warns_of_a_missthen passesinterpolation=InterpolationOption(offset_time=3600).