Repository navigation
Name the out-of-order times in the Interpolator's error - #850
Merged
caglarpir merged 1 commit intoOct 20, 2026
Merged
Conversation
The message lacked its f prefix, so it read "but got {left.time} then
{right.time}" instead of the times that were out of order. It came up
when distance sampling was handed GPX tracks out of time order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
geo.Interpolatorraised its "points must be sorted"ValueErrorfrom a string without thefprefix, so the message showed the placeholders instead of the times:It came up when distance sampling was handed GPX tracks out of time order in #841, which now sorts them. This fixes the message itself.
Adds a test that the message names the times; it fails without the fix. Unit tests, mypy, ruff and usort pass.