Conversation
|
@benmccann Your review, please. |
|
Why the failure to publish? |
|
Hmm, seems like the npm part of the publish failed https://github.com/mapbox/node-pre-gyp/actions/runs/14929738686/job/41942679960 . not sure why.... seems like it failed to find the package on npm ... maybe rerun that job? |
|
Maybe the npm token expired? npm/cli#1637 (comment) |
|
Looking at the changes between 2.0.0 and 2.0.1 i do think it is likely the token. I think the last time we had that issue because the token was only good for something like 3 months. If the token is updated I think this should rerun. it would also retry publishing on the next commit until it actually does publish. |
|
The problem is that we would need someone from mapbox to generate a new token and put in this repo’s secrets. I don’t have the access/authority to do that and I don’t think that @benmccann does either. |
|
It looks like in #888 (comment) maybe @bilindhajer helped update the token last time? last time we got the same error and it does mention 3 months in that thread. |
|
@bilindhajer any chance you can still help us update the npm key in the repo so we can push this release with abi updates for node v24? |
|
@acalcutt Any chance you could become a maintainer of this repo. I am a Python guy so I am outa my depth here. |
|
I wouldn't mind being one of the maintainers, but I am not sure I can review some of these advanced PRs either. At minimum I can try to keep this up to date as I have been in my fork. At least there are other people here interested in assisting it seems. |
|
Any idea how we could get this key updated so we can fix this publish? |
3 participants
Publish Release v2.0.1, which includes an update abi_crosswalk.json for abi 137 / node 24 (#904) and dependency updates in Upgrade tar-fs && npm install && npm audit fix (#900)