Conversation
…ove Structure - Introduced FeatureStyleEditor class to manage feature styling in a more structured way. - Refactored StyleAdapter to use ES6 class syntax, enhancing readability and maintainability. - Updated TableRenderer to extend from DataManager.TableRenderer, simplifying event handling. - Created Toolset class for managing drawing tools, improving organization of tool-related logic. - Removed legacy featureStyleEditor.js file in favor of the new FeatureStyleEditor class.
…or digitizer components
…d default icon configuration
- Introduce ExpressionEvaluator class for dynamic expression handling - Implement dynamic title expressions in DataManager - Update FormRenderer to recognize dynamic expressions
…and 'text' and implement title attribute handling
…p based on editability
…fy FormRenderer to apply 'd-block' class for responsive images
…or a more compact layout
…ve mobile dialog functionality
Member
|
Shows Lupe, but does not zoom |
PhilVanB
approved these changes
Feb 2, 2026
Contributor
PhilVanB
left a comment
PhilVanB
left a comment
There was a problem hiding this comment.
Code-wise, that's a nice refactoring.
Phocacius
reviewed
Feb 3, 2026
Member
Phocacius
left a comment
Phocacius
left a comment
There was a problem hiding this comment.
Thanks for the conversion to Javascript classes 😊
Apart from the comments in code, one thing I noticed in the frontend: When using tabs the container is a bit too wide resulting in a scrollbar being visible where it should not be, even when making the popup window very wide:
src/Mapbender/DataManagerBundle/Resources/public/ExpressionEvaluator.js
Outdated
Show resolved
Hide resolved
src/Mapbender/DataManagerBundle/Resources/public/MbDataManager.js
Outdated
Show resolved
Hide resolved
src/Mapbender/DataManagerBundle/Resources/public/MbDataManager.js
Outdated
Show resolved
Hide resolved
… and improve dependency injection
…a selector change
…expression support updates
Phocacius
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataManager & Digitizer: Dialog Improvements and Mobile Optimization
This PR implements comprehensive improvements to the DataManager and Digitizer dialogs, focusing on usability, mobile responsiveness, and enhanced configuration options.
Dialog System Modernization
Dialog Configuration Enhancements
data.title + " - " + data.ort)${data.property}syntax in expressionsForm Item Improvements
titleattribute support for type: labeltitle,labelandtexttypes (similar to existinghtmltype)"'Titel lautet: ' + data.title""${data.title}""(function(){ return data.gemarkung ? 'Gemarkung: ' + data.gemarkung : 'Gemarkung:'; })()"Display-Only Mode Detection
Mobile Optimization