smartcontract: add AccessPassType::EdgeSeat(Pubkey) variant#3632
Open
juan-malbeclabs wants to merge 4 commits intomainfrom
Open
smartcontract: add AccessPassType::EdgeSeat(Pubkey) variant#3632juan-malbeclabs wants to merge 4 commits intomainfrom
juan-malbeclabs wants to merge 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
AccessPassType::EdgeSeat(Pubkey)variant to tie an access pass to a specific onchain Seat pubkey, mirroring the existingSolanaValidator(Pubkey)pattern--accesspass-type edge-seat --seat <PUBKEY>support toaccess-pass set--edge-seatand--seat-pubkeyfilter flags toaccess-pass listDiff Breakdown
Mostly test additions to cover the two new CLI code paths; core change is small and additive.
Key files (click to expand)
smartcontract/cli/src/accesspass/set.rs— addsEdgeSeattoCliAccessPassType,--seatarg, match arm inexecute(), and two new testssmartcontract/programs/doublezero-serviceability/src/state/accesspass.rs— addsEdgeSeat(Pubkey)variant with serde,Display,to_discriminant_string, andValidate(rejects default pubkey)smartcontract/cli/src/accesspass/list.rs— adds--edge-seatand--seat-pubkeyfilter flagssmartcontract/programs/doublezero-serviceability/src/processors/accesspass/set.rs— adds null-pubkey guard forEdgeSeatmatching the existingSolanaValidatorcheckTesting Verification
access-pass settests pass (16 tests unmodified + 2 new:test_cli_accesspass_set_edge_seat_missing_seatandtest_cli_accesspass_set_edge_seat_success)make rust-lintpasses cleanly