Skip to content

Conversation

@adilraza99
Copy link
Contributor

Fixes #826

This PR adds documentation to the plot_frequencies_time_series function to clarify what the displayed error bars represent.

Changes

  • Updated the docstring returns section in malariagen_data/anoph/frq_base.py
  • Documented that error bars represent 95% confidence intervals
  • Specified Wilson score method usage via statsmodels.stats.proportion.proportion_confint()
  • Clarified asymmetric upper/lower bounds behavior

Verification

  • Documentation-only change (no logic modified)
  • No imports or dependencies changed
  • Clean single commit
  • Formatting and line length compliant
  • Safe for CI validation

@adilraza99
Copy link
Contributor Author

Hi maintainers,

This PR only updates documentation and does not modify any application logic or dependencies.
Please let me know if you'd like anything adjusted or clarified.

Thanks!

@adilraza99 adilraza99 force-pushed the fix/docs-error-bars-ag3-826 branch from f971eef to 7b8ac64 Compare February 9, 2026 11:14
@adilraza99
Copy link
Contributor Author

@jonbrenas could you please take a look at this PR? The documentation updates address the issue and have been verified on my side. Just want to confirm everything looks good from your perspective.

Copy link
Collaborator

@jonbrenas jonbrenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonbrenas jonbrenas merged commit 2d63f0d into malariagen:master Feb 9, 2026
3 of 5 checks passed
@jonbrenas
Copy link
Collaborator

Thanks, @adilraza99. This is perfect!

@adilraza99
Copy link
Contributor Author

@jonbrenas Thanks a lot, I’m really glad the changes were helpful! I enjoyed working on this PR and would love to keep contributing to the project.

I’m also exploring potential GSoC organizations this year and was looking into Sanger Tree of Life. I didn’t see this repository listed there, so I wanted to ask whether continuing to contribute here would be a good way to get more involved with the project overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ag3.plot_frequencies_time_series error bars API

2 participants