Skip to content

fix: scope un-themed editor color fallback so dark-mode ramp wins #9754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Liewzheng wants to merge 1 commit into
base: preview
Choose a base branch
from
+8 −4
Open

fix: scope un-themed editor color fallback so dark-mode ramp wins #9754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/space/styles/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@
* @plane/editor/styles (imported above), which is their single source of truth.
* Only the un-themed :root fallback below is kept: the editor package declares
* background colors solely under [data-theme*="light"] / [data-theme*="dark"],
* so without this they are undefined until a theme lands on the element. */
:root {
* so without this they are undefined until a theme lands on the element.
* Scoped with :not() so it never overrides the themed ramps — as a plain :root
* rule later in the bundle it would win over them regardless of theme. */
:root:not([data-theme*="light"]):not([data-theme*="dark"]) {
--editor-colors-gray-background: #d6d6d8;
--editor-colors-peach-background: #ffd5d7;
--editor-colors-pink-background: #fdd4e3;
Expand Down
6 changes: 4 additions & 2 deletions apps/web/styles/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@
* @plane/editor/styles (imported above), which is their single source of truth.
* Only the un-themed :root fallback below is kept: the editor package declares
* background colors solely under [data-theme*="light"] / [data-theme*="dark"],
* so without this they are undefined until a theme lands on the element. */
:root {
* so without this they are undefined until a theme lands on the element.
* Scoped with :not() so it never overrides the themed ramps — as a plain :root
* rule later in the bundle it would win over them regardless of theme. */
:root:not([data-theme*="light"]):not([data-theme*="dark"]) {
--editor-colors-gray-background: #d6d6d8;
--editor-colors-peach-background: #ffd5d7;
--editor-colors-pink-background: #fdd4e3;
Expand Down